-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-8330][VL] Improve convert the viewfs path to hdfs path #8331
Conversation
Run Gluten Clickhouse CI on x86 |
@@ -377,26 +378,28 @@ case class WholeStageTransformer(child: SparkPlan, materializeInput: Boolean = f | |||
val allScanSplitInfos = | |||
getSplitInfosFromPartitions(basicScanExecTransformers, allScanPartitions) | |||
if (GlutenConfig.getConf.enableHdfsViewfs) { | |||
val viewfsToHdfsCache: mutable.Map[String, String] = mutable.Map.empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this cache take too much memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the size of this map is at most equal to the total number of partitions of these tables.
gluten-substrait/src/main/scala/org/apache/hadoop/fs/viewfs/ViewFileSystemUtils.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your work. Except two small comments.
gluten-substrait/src/main/scala/org/apache/hadoop/fs/viewfs/ViewFileSystemUtils.scala
Show resolved
Hide resolved
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala
Outdated
Show resolved
Hide resolved
Run Gluten Clickhouse CI on x86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Run Gluten Clickhouse CI on x86 |
@wangyum Can you help to resolve the following compile issue? Thanks.
|
Run Gluten Clickhouse CI on x86 |
What changes were proposed in this pull request?
(Fixes: #8330)
How was this patch tested?
Manual tests, before: 225007 ms, after: 1330 ms:
Output: