Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2932: Fix for NodeFmtLib.strNT and added variants for Triple and Quad. #2933

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

Aklakan
Copy link
Contributor

@Aklakan Aklakan commented Jan 8, 2025

GitHub issue resolved #2932

Pull request Description:

  • Fixes NodeFmtLib.strNT
  • Also adds strNT and strNQ variants for formatting as N-Quads (and N-Triples). It seems that so far there were no reliable util methods to create a single valid NQ string - unless one goes through riot. None of the formatting methods in NodeFmtLib and FmtUtils seem to produce NQ.

  • Tests are included.
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.


See the Apache Jena "Contributing" guide.

@Aklakan Aklakan force-pushed the 2025-01-08_nodefmt-nt-fix branch from 63275c4 to d9d63cc Compare January 8, 2025 23:07
@Aklakan Aklakan force-pushed the 2025-01-08_nodefmt-nt-fix branch from d9d63cc to 0ed3d43 Compare January 8, 2025 23:15
@afs afs self-assigned this Jan 11, 2025
@afs afs added RIOT enhancement Incrementally add new feature labels Jan 11, 2025
@afs afs merged commit 762cd45 into apache:main Jan 11, 2025
@afs
Copy link
Member

afs commented Jan 11, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Incrementally add new feature RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeFmtLib.strNT incorrectly uses ttlFormatter
2 participants