cypress-run to depend on a maven build #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping the timeout on the maven step ... |
kinow
approved these changes
Jan 23, 2025
|
The fun thing is that it is the updated workflow in the PR is the one run for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
cyrpress-runis made to run after the build job. It appears that the jobs run in parallel at the moment - I see the Cypress runs finish before the build step has. The Cypress job is quick.Change the build step to do a "dev" build. Currently, it does not build from the start of the Jena build. If there has been a change in earlier dependency, then the Fuseki steps fail.
If this become smooth, we should consider combining into a PR workflow.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.