Revert "Build: Fix module pathname for gppkg"

This reverts commit e1337ae.

The reverted commit was creating a symlink for the lilbmadlib.so file.
Since we decided to use the dynamic_library_path GUC, this link is
and the associated changes are not needed any more.

deploy/gppkg/gppkg_spec.yml.in

@@ -17,6 +17,3 @@ PostInstall:
            echo 'For additional options run:';
            echo '$ madpack --help';
            echo 'Release notes and additional documentation can be found at http://madlib.apache.org';"
-PostUninstall:
-- Master: "rm $GPHOME/lib/postgresql/libmadlib.so"
-- Segment: "rm $GPHOME/lib/postgresql/libmadlib.so"

deploy/gppkg/madlib.spec.in

@@ -54,8 +54,6 @@ ln -nsf $RPM_INSTALL_PREFIX/madlib/Versions/$MADLIB_VERSION $RPM_INSTALL_PREFIX/
 ln -nsf $RPM_INSTALL_PREFIX/madlib/Current/bin $RPM_INSTALL_PREFIX/madlib/bin
 ln -nsf $RPM_INSTALL_PREFIX/madlib/Current/doc $RPM_INSTALL_PREFIX/madlib/doc
 
-ln -nsf $RPM_INSTALL_PREFIX/madlib/Current/ports/greenplum/@GPDB_VERSION@/lib/libmadlib.so $RPM_INSTALL_PREFIX/lib/postgresql/libmadlib.so
-
 # creating symlink for madpack (does not work at present)
 # find $RPM_INSTALL_PREFIX/bin/madpack -type f -exec mv {} $RPM_INSTALL_PREFIX/bin/old_madpack \; 2>/dev/null
 # ln -nsf $RPM_INSTALL_PREFIX/madlib/Current/bin/madpack $RPM_INSTALL_PREFIX/bin/madpack

src/madpack/madpack.py

@@ -1232,13 +1232,6 @@ def get_madlib_function_drop_str(schema):
     for idx in range(len(madlib_functions)):
 
         func = madlib_functions[idx]
-
-        # Filter out the DEFAULT value from the function arguments
-        # DROP FUNCTION statements do not need or allow default values:
-        # DROP FUNCTION foo(bar INTEGER DEFAULT 0);
-        func['args'] = func['args'].split(',')
-        func['args'] = [i.split('DEFAULT')[0] for i in func['args']]
-        func['args'] = ', '.join(func['args'])
         # We don't drop type related functions
         no_drop = ['bytea8', 'float8arr', 'svec']
         if not any(x in func['name'] for x in no_drop):
@@ -1410,10 +1403,7 @@ def main(argv):
             maddir_conf = maddir + "/config"
 
         global maddir_lib
-        if portid == 'greenplum' and \
-           os.path.islink(maddir + "/../../../lib/postgresql/libmadlib.so"):
-           maddir_lib = '$libdir/libmadlib.so'
-        elif os.path.isfile(maddir + "/ports/" + portid + "/" + dbver +
+        if os.path.isfile(maddir + "/ports/" + portid + "/" + dbver +
                           "/lib/libmadlib.so"):
             maddir_lib = maddir + "/ports/" + portid + "/" + dbver + \
                 "/lib/libmadlib.so"