[iceberg][doc] add docs about iceberg migration #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyubin117
reviewed
Feb 19, 2025
docs/content/flink/procedures.md
Outdated
| </tr> | ||
| <tr> | ||
| <td>migrate_iceberg_table</td> | ||
| <td> |
There was a problem hiding this comment.
It would better to move the part to place after migrate_table
There was a problem hiding this comment.
Good idea! I'll move this item after migrate_table.
liyubin117
reviewed
Feb 19, 2025
docs/content/flink/procedures.md
Outdated
| <td> | ||
| To migrate iceberg table to paimon. Arguments: | ||
| <li>source_table: string type, is used to specify the source iceberg table to migrate, it's required.</li> | ||
| <li>iceberg_options: string type, is used to specify the configuration of migration, multiple configuration items are separated by commas. it's required.</li> |
There was a problem hiding this comment.
Doc conflicts with hint definition, is iceberg_options required or optional?
@ProcedureHint(
argument = {
@ArgumentHint(name = "source_table", type = @DataTypeHint("STRING")),
@ArgumentHint(
name = "iceberg_options",
type = @DataTypeHint("STRING"),
isOptional = true),
@ArgumentHint(name = "options", type = @DataTypeHint("STRING"), isOptional = true),
@ArgumentHint(
name = "parallelism",
type = @DataTypeHint("Integer"),
isOptional = true)
})
There was a problem hiding this comment.
Thanks for the correction！ iceberg_options is required. There is a bug in the definition, I'll fix it.
LsomeYeah
force-pushed
the
migrate-iceberg-doc-commit
branch
from
8ad3ddc to
55a501d
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
add the documents about iceberg migration
Tests
API and Format
Documentation