Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

PARQUET-1350: [C++] Use abstract ResizableBuffer instead of concrete PoolBuffer #477

Closed
wants to merge 2 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jul 17, 2018

No description provided.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @pitrou!

@wesm wesm closed this in 049af6f Jul 23, 2018
@pitrou pitrou deleted the PARQUET-1350-pool-buffer branch July 23, 2018 19:01
@cpcloud
Copy link
Contributor

cpcloud commented Jul 28, 2018

@xhochy This is the PR that is causing release headaches now. We now have to 1) build against parquet-cpp master, 2) cut a new release of parquet-cpp, or 3) revert the arrow commit. I'm not sure that it's benefiting the community to keep these projects separate anymore given the pace of change in arrow, since parquet-cpp has arrow as a dependency. We need some solution going forward. A monorepo is going to make the repo bigger, but we will be able to catch API breakages like this immediately.

@wesm
Copy link
Member

wesm commented Jul 28, 2018

We will have to build against parquet-cpp master in the meantime.

Having parquet-cpp depend on the "platform" code (IO, memory management, concurrency management, algorithms) in Arrow is the only really practical option but we have been dealing with the awkward circular dependency for a while now.

As commented in apache/arrow#2326 (comment) moving these communities to a monorepo structure would make all of these problems go away immediately. With the release automation work in Arrow we could also release much more often

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants