Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Remove duplicate dependencies in pom.xml #23440

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 11, 2024

Motivation

Pulsar maven build shows some warning at the beginning:

[WARNING] Some problems were encountered while building the effective model for org.apache.pulsar:pulsar-common:jar:4.0.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: com.google.re2j:re2j:jar -> duplicate declaration of version (?) @ line 250, column 17
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.apache.pulsar:pulsar-client-tools:jar:4.0.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: ${project.groupId}:pulsar-cli-utils:jar -> duplicate declaration of version ${project.version} @ line 79, column 16
[WARNING]

Modifications

  • fix the warnings by removing the duplicate dependencies

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.0.0 milestone Oct 11, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 11, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (bbc6224) to head (dbc0cc0).
Report is 667 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23440      +/-   ##
============================================
+ Coverage     73.57%   74.27%   +0.70%     
- Complexity    32624    34960    +2336     
============================================
  Files          1877     1953      +76     
  Lines        139502   147177    +7675     
  Branches      15299    16204     +905     
============================================
+ Hits         102638   109321    +6683     
- Misses        28908    29416     +508     
- Partials       7956     8440     +484     
Flag Coverage Δ
inttests 27.27% <ø> (+2.69%) ⬆️
systests 24.33% <ø> (+0.01%) ⬆️
unittests 73.64% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 632 files with indirect coverage changes

@lhotari lhotari merged commit 807d189 into apache:master Oct 11, 2024
55 of 59 checks passed
@lhotari lhotari modified the milestones: 4.1.0, 4.0.0 Oct 11, 2024
lhotari added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants