Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Zeta] Improve the Success Rate of Resource Allocation for Large Tasks in Dynamic Slot Mode. #8242

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

xiaochen-zhou
Copy link
Contributor

Purpose of this pull request

By selecting workers with the least remaining eligible resources, aim to preserve those with larger resources to improve the success rate of tasks requiring significant resources.

Does this PR introduce any user-facing change?
no

How was this patch tested?
exist tests

Check list

@@ -228,6 +228,8 @@ private void executeJob(TestContainer container, String job1, String job2)
}

@TestTemplate
@Disabled(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? cc @zhangshenghang

@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 9, 2024

Hi @xiaochen-zhou , this PR seems to do the same optimization as #8233.

@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 9, 2024

This change will cause unbalanced load in the cluster. Why not consider controlling job scheduling through tags? https://seatunnel.apache.org/docs/2.3.8/seatunnel-engine/resource-isolation

@xiaochen-zhou
Copy link
Contributor Author

This change will cause unbalanced load in the cluster. Why not consider controlling job scheduling through tags? https://seatunnel.apache.org/docs/2.3.8/seatunnel-engine/resource-isolation

This change will cause unbalanced load in the cluster. Why not consider controlling job scheduling through tags? https://seatunnel.apache.org/docs/2.3.8/seatunnel-engine/resource-isolation

This operation is after tag_filer and targets the success rate within a team. For example, I have three teams: SLA, High Priority, Medium Priority, and Low Priority. I want to improve the success rate of large resource tasks within the high priority tasks.
image

@xiaochen-zhou
Copy link
Contributor Author

This change will cause unbalanced load in the cluster. Why not consider controlling job scheduling through tags? https://seatunnel.apache.org/docs/2.3.8/seatunnel-engine/resource-isolation

However, I think that the unbalanced load is only at the team level, and I feel that it won't have any negative impact.

@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 9, 2024

This change will cause unbalanced load in the cluster. Why not consider controlling job scheduling through tags? https://seatunnel.apache.org/docs/2.3.8/seatunnel-engine/resource-isolation

However, I think that the unbalanced load is only at the team level, and I feel that it won't have any negative impact.

OK, we should add new strategy not change the RANDOM strategy bahavior.

@hailin0
Copy link
Member

hailin0 commented Dec 9, 2024

This change will cause unbalanced load in the cluster. Why not consider controlling job scheduling through tags? https://seatunnel.apache.org/docs/2.3.8/seatunnel-engine/resource-isolation

However, I think that the unbalanced load is only at the team level, and I feel that it won't have any negative impact.

OK, we should add new strategy not change the RANDOM strategy bahavior.

+1

@liunaijie
Copy link
Member

Hi @xiaochen-zhou , this PR seems to do the same optimization as #8233.

+1, looks it's similar. cc @zhangshenghang

@zhangshenghang
Copy link
Member

zhangshenghang commented Dec 9, 2024 via email

@xiaochen-zhou
Copy link
Contributor Author

Hi @xiaochen-zhou , this PR seems to do the same optimization as #8233. +1, looks it's similar. cc @zhangshenghang
@xiaochen-zhou Hi , because I made modifications to the structure, you can wait until # 8223 is merged before adding modifications, and I will complete the PR optimization as soon as possible .

2024年12月9日 下午5:11,Jarvis @.***> 写道: Hi @xiaochen-zhou https://github.com/xiaochen-zhou , this PR seems to do the same optimization as #8233 <#8233>. +1, looks it's similar. cc @zhangshenghang https://github.com/zhangshenghang — Reply to this email directly, view it on GitHub <#8242 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHAOLX5EDZUHHI5T6DYYA4D2EVNFTAVCNFSM6AAAAABTH7FOP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRXGM2DGMJSGM. You are receiving this because you were mentioned.

ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants