[Feature][Transform][Replace]Replace support schema change #8313
Conversation
| ((SeaTunnelMapTransform<SeaTunnelRow>) transformMap.get(event.tablePath().toString())) | ||
| .mapSchemaChangeEvent(event); | ||
|
|
||
| return event; |
There was a problem hiding this comment.
| ((SeaTunnelMapTransform<SeaTunnelRow>) transformMap.get(event.tablePath().toString())) | |
| .mapSchemaChangeEvent(event); | |
| return event; | |
| return ((SeaTunnelMapTransform<SeaTunnelRow>) transformMap.get(event.tablePath().toString())) | |
| .mapSchemaChangeEvent(event); |
There was a problem hiding this comment.
Please update https://github.com/apache/seatunnel/blob/dev/docs/en/concept/schema-evolution.md to let users know we can use transform with schema evolution now.
| null); | ||
|
|
||
| @Test | ||
| public void testRepalceTransformSchangeChange() { |
There was a problem hiding this comment.
Could you add some test case to make sure the transform fine after schema changed? For example, still can replace data as expected.
|
I think we should add some e2e case. |
Hi @dailai , I think the logic already be tested by https://github.com/apache/seatunnel/pull/8313/files#diff-835463340eff995995f88a3c8b8a25e873860a751b91b4f32322224e0346fab1R89. Should we continue add e2e test case? PS: I think we shoud move some test case from e2e to unit test. The e2e test case is too much. WDYT? |
UT covers logic and is not a substitute for e2e testing. The test scenario is different. |
Purpose of this pull request
#8255
Does this PR introduce any user-facing change?
NO