Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17630 Add SolrCloudManager.getSolrClient #3049

Merged

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Jan 21, 2025

and ZkController.getSolrClient for a canonical node managed CloudSolrClient. Deprecate SolrCloudManager.request

https://issues.apache.org/jira/browse/SOLR-17630

This PR re-routes usages of SolrClientCache and SolrCloudManager.request that should now be using this instance.

and ZkController.getSolrClient for a canonical node managed CloudSolrClient.
Deprecate SolrCloudManager.request
@dsmiley
Copy link
Contributor Author

dsmiley commented Feb 6, 2025

Needs a CHANGES.txt but it's otherwise ready. Planning to add in "Other":
Added a node-wide CloudSolrClient to ZkController, and accessible via SolrCloudManager too. Uses Jetty HttpClient. Deprecated CloudSolrClient.getSolrClientCache. Redirected some callers.
Oh yeah; and want to deprecate CoreContainer.getSolrClientCache to further discourage anyone from using it.

@dsmiley dsmiley merged commit 158074d into apache:main Feb 13, 2025
2 of 3 checks passed
@dsmiley dsmiley deleted the SOLR-17630-SolrCloudManager.getSolrClient branch February 13, 2025 22:04
dsmiley added a commit that referenced this pull request Feb 13, 2025
and ZkController.getSolrClient for a canonical node managed CloudSolrClient.
Deprecate SolrCloudManager.request
Deprecate CoreContainer.getSolrClientCache

(cherry picked from commit 158074d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant