-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17673: Disable multithreaded search at the node level by default #3183
SOLR-17673: Disable multithreaded search at the node level by default #3183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's Varun's relation here?
He did a lot of debugging for the first calling out of this: https://issues.apache.org/jira/browse/SOLR-17642 Not really sure why that had to be clarified though... |
I know I missed reviewing this - but this completely removes the ability to have it figure out number of processors right? I wonder if it would make sense to set the default to -1 in the solr.xml we ship if the value is 0 - set to num processors, its its -1 disable, if anything else use that value. this is similar to ffde419 that remove the config and added the num processors in java code. |
Ok, yeah, I was a bit lazy with the solution. But I agree that it should be possible. Though from my (probably bad) viewpoint, Let me come up with something for this. |
@@ -67,6 +67,12 @@ It is always strongly recommended that you fully reindex your documents after a | |||
In Solr 8, it was possible to add docValues to a schema without re-indexing via `UninvertDocValuesMergePolicy`, an advanced/expert utility. | |||
Due to changes in Lucene 9, that isn't possible any more. | |||
|
|||
== Solr 9.8.1 | |||
=== Configuration | |||
In solrconfig.xml, the `indexSearcherExecutorThreads` now defaults to 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No; in solr.xml.
I wish this had a default using an EnvUtils read so we needn't edit a config file to manipulate it. Env vars are more convenient for random/standalone toggles/configurables.
https://issues.apache.org/jira/browse/SOLR-17673