Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17518: Remove deprecated XML methods from UpdateRequest #3215

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

psalagnac
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17518

This is a follow-up of #3200.
Deprecated methods are now removed in Solr 10.

Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems slightly odd that the one test needed some extra code? is there a refactoring of that test that would eliminate the getXML helper method?

@psalagnac
Copy link
Contributor Author

Thanks a good point, thanks. All other tests use test utility code for that!

@psalagnac psalagnac merged commit 085bfc6 into apache:main Feb 27, 2025
3 of 4 checks passed
@psalagnac psalagnac deleted the xml branch February 27, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants