Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Persian translations #29580

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CodeWithEmad
Copy link
Contributor

@CodeWithEmad CodeWithEmad commented Jul 12, 2024

This will add the Persian translations as well as new strings to other languages using scripts/translations/babel_update.sh

Copy link

request-info bot commented Jul 12, 2024

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label Jul 12, 2024
@github-actions github-actions bot added i18n Namespace | Anything related to localization packages labels Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.46%. Comparing base (76d897e) to head (1308819).
Report is 1396 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29580       +/-   ##
===========================================
+ Coverage   60.48%   83.46%   +22.97%     
===========================================
  Files        1931      545     -1386     
  Lines       76236    39036    -37200     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32582    -13532     
+ Misses      28017     6454    -21563     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.49% <ø> (-0.68%) ⬇️
javascript ?
mysql 75.87% <ø> (?)
postgres 75.94% <ø> (?)
presto 53.02% <ø> (-0.78%) ⬇️
python 83.46% <ø> (+19.97%) ⬆️
sqlite 75.45% <ø> (?)
unit 61.00% <ø> (+3.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

You can install and run the pre-commit hook to fix the linting errors. The SQLite test failure is probably unrelated.

@rusackas

This comment was marked as resolved.

This comment was marked as outdated.

@CodeWithEmad CodeWithEmad force-pushed the feat/persian-translations branch from 456afa3 to 888c154 Compare July 16, 2024 12:26
@CodeWithEmad
Copy link
Contributor Author

Fixed. I checked the test env (which is such a cool command!) but haven't seen the flags. in login. maybe I should add it somewhere else?

@rusackas
Copy link
Member

Oh... turning on the test language file in config.py should work for this ephemeral environment testing (or local testing, I believe)

superset/config.py Outdated Show resolved Hide resolved
@CodeWithEmad CodeWithEmad force-pushed the feat/persian-translations branch from ad65009 to 6bc55cf Compare July 17, 2024 20:49
@rusackas
Copy link
Member

/testenv up

Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.220.159.126:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@CodeWithEmad
Copy link
Contributor Author

OMG. I'm so so sorry. It's working fine in the test env. There must be something wrong with my local setup. I'll close the issue, but keep this PR as a draft so I can add translations in the future.

@CodeWithEmad CodeWithEmad force-pushed the feat/persian-translations branch from 6bc55cf to c2a3f04 Compare October 21, 2024 08:03
@github-actions github-actions bot added i18n:spanish Translation related to Spanish language i18n:italian Translation related to Italian language i18n:french Translation related to French language i18n:chinese Translation related to Chinese language i18n:japanese Translation related to Japanese language i18n:russian Translation related to Russian language i18n:korean Translation related to Korean language i18n:dutch i18n:slovak and removed packages labels Oct 21, 2024
@CodeWithEmad
Copy link
Contributor Author

CodeWithEmad commented Oct 21, 2024

Hey @rusackas, could you please take a moment to review this when you have a chance? Thank you!
Also, I have a couple of questions:

  • Can I suggest moving translations to a translation manager service (like Transifex) as a SIP? Translators should not have any technical ability to add translations to the service. I'm sure if we add more languages, we can have more contributors joining the superset.
  • Looks like only translating this project is not enough and we have to dig deeper. Are there other projects we have to translate to have a 100% native superset? :)

@CodeWithEmad
Copy link
Contributor Author

CodeWithEmad commented Oct 22, 2024

Also, dpgaspar/Flask-AppBuilder#2278 will add the Persian translations to the Flask AppBuilder project.

UPDATE: This PR is merged

@CodeWithEmad CodeWithEmad force-pushed the feat/persian-translations branch from 2f2dd2c to d968bc9 Compare January 22, 2025 12:29
@CodeWithEmad CodeWithEmad requested a review from rusackas January 22, 2025 12:29
@CodeWithEmad CodeWithEmad force-pushed the feat/persian-translations branch from d968bc9 to 1308819 Compare February 1, 2025 06:08
@CodeWithEmad
Copy link
Contributor Author

Hey folks. I've been resolving conflicts for a while now. Does anyone interested in reviewing this?

@rusackas @mistercrunch

@mistercrunch
Copy link
Member

I did a quick look on the .po files trying to make sure we're not loosing any translations as part of this PR. It seems either a lot of strings got orphaned since the last update (maybe due to code deprecations as part of the 5.0 breaking window) , or there may be something wrong happening in the process.

Didn't have time to go "forensics-level" on it, but worth digging in a bit deeper to try and validate that the orphaned strings should indeed be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:brazilian i18n:chinese Translation related to Chinese language i18n:dutch i18n:french Translation related to French language i18n:general Related to translations i18n:italian Translation related to Italian language i18n:japanese Translation related to Japanese language i18n:korean Translation related to Korean language i18n:portuguese i18n:russian Translation related to Russian language i18n:slovak i18n:spanish Translation related to Spanish language i18n:traditional-chinese i18n:ukrainian i18n Namespace | Anything related to localization need:more-info Requires more information from author size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants