THRIFT-5667: Make ThriftConfig.cmake relocatable #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client: cpp The current ThriftConfig.cmake isn't relocatable. It means that we can't move ThriftConfig.cmake installed by "make install". In general, users don't need to move ThriftConfig.cmake installed by "make install" but some packaging systems such as conda and MSYS2 needs to move. Because users of these packaging systems may use different prefix. For example, conda may be used with ~alice/my-conda and ~bob/conda as base directory. CMake has a feature to make Config.cmake relocatable: https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html We can use it to make ThriftConfig.cmake relocatable.
|
Could someone review this? |
Jens-G
added
build and general CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: cpp
The current ThriftConfig.cmake isn't relocatable. It means that we can't move ThriftConfig.cmake installed by "make install".
In general, users don't need to move ThriftConfig.cmake installed by "make install" but some packaging systems such as conda and MSYS2 needs to move. Because users of these packaging systems may use different prefix. For example, conda may be used with ~alice/my-conda and ~bob/conda as base directory.
CMake has a feature to make Config.cmake relocatable: https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html
We can use it to make ThriftConfig.cmake relocatable.
[skip ci]anywhere in the commit message to free up build resources.