Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOP-3226. Use central repo, not repository.apache.org #86

Closed
wants to merge 1 commit into from

Conversation

adoroszlai
Copy link

@adoroszlai adoroszlai commented Dec 14, 2024

What changes were proposed in this pull request?

Build tries to download non-Apache artifacts from repository.apache.org:

[INFO] Downloading from apache.releases.https: https://repository.apache.org/content/repositories/releases/org/junit/junit-bom/5.11.0/junit-bom-5.11.0.pom
[INFO] Downloading from jboss.org: https://repository.jboss.org/nexus/content/repositories/thirdparty-releases/org/junit/junit-bom/5.11.0/junit-bom-5.11.0.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.11.0/junit-bom-5.11.0.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.11.0/junit-bom-5.11.0.pom (5.6 kB at 706 kB/s)
  • Remove repository.apache.org for releases.
  • Add central repo definition. This is inherited, too, but repos in pom.xml have higher precedence. So this is needed only to avoid hitting jboss.org unnecessarily.

https://issues.apache.org/jira/browse/FOP-3226

How was this patch tested?

$ mvn -DskipTests clean package
...
[INFO] Reactor Summary for Apache FOP Parent 2.10.0-SNAPSHOT:
[INFO] 
[INFO] Apache FOP Parent .................................. SUCCESS [  0.123 s]
[INFO] Apache FOP Utilities ............................... SUCCESS [  1.792 s]
[INFO] Apache FOP Events .................................. SUCCESS [  0.425 s]
[INFO] Apache FOP Core .................................... SUCCESS [ 17.353 s]
[INFO] Apache FOP All-In-One .............................. SUCCESS [  0.022 s]
[INFO] Apache FOP Sandbox ................................. SUCCESS [  0.117 s]
[INFO] Apache FOP Servlet ................................. SUCCESS [  1.658 s]
[INFO] Apache FOP Transcoder .............................. SUCCESS [  0.393 s]
[INFO] Apache FOP Transcoder All-In-One ................... SUCCESS [  0.221 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

@adoroszlai
Copy link
Author

adoroszlai commented Dec 14, 2024

Sorry, the diff shown in GitHub (or by git defaults) is a bit confusing. Here's a nicer version, which can be obtained by

git show --diff-algorithm=patience
diff --git pom.xml pom.xml
index 3260fdb54..7ef2f60ce 100644
--- pom.xml
+++ pom.xml
@@ -155,6 +155,14 @@
   </scm>
 
   <repositories>
+    <repository>
+      <id>central</id>
+      <name>Central Repository</name>
+      <url>https://repo.maven.apache.org/maven2</url>
+      <snapshots>
+        <enabled>false</enabled>
+      </snapshots>
+    </repository>
     <repository>
       <id>apache.snapshots.https</id>
       <url>https://repository.apache.org/content/repositories/snapshots</url>
@@ -165,16 +173,6 @@
         <enabled>true</enabled>
       </snapshots>
     </repository>
-    <repository>
-      <id>apache.releases.https</id>
-      <url>https://repository.apache.org/content/repositories/releases</url>
-      <releases>
-        <enabled>true</enabled>
-      </releases>
-      <snapshots>
-        <enabled>false</enabled>
-      </snapshots>
-    </repository>
     <repository>
       <id>jboss.org</id>
       <url>https://repository.jboss.org/nexus/content/repositories/thirdparty-releases/</url>

@adoroszlai
Copy link
Author

Thanks @simonsteiner1984 for committing this as d0c8f24.

@adoroszlai adoroszlai closed this Dec 15, 2024
@adoroszlai adoroszlai deleted the FOP-3226 branch December 15, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant