Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #1071

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typo #1071

wants to merge 2 commits into from

Conversation

KangZhiDong
Copy link
Contributor

fix typo

fix typo
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution
The patch is too small for a commit

@KangZhiDong KangZhiDong reopened this Sep 4, 2019
@@ -382,7 +382,7 @@ public void testConnectWithoutSSLToNonStrictServerPartialWrite() throws Exceptio
}

/**
* Attempting to connect to a SSL-only server without SSL should fail.
* Attempting to connect to an SSL-only server without SSL should fail.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It's weird that SSL doesn't start with a vowel(a,e,i,o,u), but use an
  • @eolivelli It's now not trivial to merge? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants