ZOOKEEPER-3863: correct junit test timeout #1459

tisonkun · 2020-09-17T09:47:44Z

tisonkun · 2020-09-17T09:48:12Z

I'm not sure whether we have to file an issue. If so I'm ok to file one.

eolivelli · 2020-09-17T10:03:00Z

@tisonkun thanks for pointing this out
but the build fails with your patch


[2020-09-17T09:49:01.077Z] [INFO] Finished at: 2020-09-17T09:49:00Z

[2020-09-17T09:49:01.077Z] [INFO] ------------------------------------------------------------------------

[2020-09-17T09:49:01.077Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project zookeeper: Compilation failure

[2020-09-17T09:49:01.077Z] [ERROR] /home/jenkins/jenkins-home/workspace/eper-precommit-github-pr_PR-1459/zookeeper-server/src/test/java/org/apache/zookeeper/test/ReadOnlyModeTest.java:[248,21] cannot find symbol

[2020-09-17T09:49:01.077Z] [ERROR]   symbol:   method timeout()

[2020-09-17T09:49:01.077Z] [ERROR]   location: @interface org.junit.jupiter.api.Test

[2020-09-17T09:49:01.077Z] [ERROR] 

[2020-09-17T09:49:01.077Z] [ERROR] -> [Help 1]

eolivelli · 2020-09-17T10:03:49Z

can you please include the original JIRA id in the commit message ?
this is part of the same issue

tisonkun · 2020-09-17T10:49:23Z

@tisonkun thanks for pointing this out
but the build fails with your patch


[2020-09-17T09:49:01.077Z] [INFO] Finished at: 2020-09-17T09:49:00Z

[2020-09-17T09:49:01.077Z] [INFO] ------------------------------------------------------------------------

[2020-09-17T09:49:01.077Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project zookeeper: Compilation failure

[2020-09-17T09:49:01.077Z] [ERROR] /home/jenkins/jenkins-home/workspace/eper-precommit-github-pr_PR-1459/zookeeper-server/src/test/java/org/apache/zookeeper/test/ReadOnlyModeTest.java:[248,21] cannot find symbol

[2020-09-17T09:49:01.077Z] [ERROR]   symbol:   method timeout()

[2020-09-17T09:49:01.077Z] [ERROR]   location: @interface org.junit.jupiter.api.Test

[2020-09-17T09:49:01.077Z] [ERROR] 

[2020-09-17T09:49:01.077Z] [ERROR] -> [Help 1]

The patch is just fix this issue. Did pr-merge run with previous version? Locally verified and it seems Travis gave green.

tisonkun · 2020-09-17T10:49:40Z

can you please include the original JIRA id in the commit message ?
this is part of the same issue

ok

eolivelli · 2020-09-17T11:36:09Z

@tisonkun I have restarted the build
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1459/3/pipeline

eolivelli · 2020-09-17T11:43:42Z

Locally master branch wasn't able to compile.
I have merged this patch, no more issues.

It is very weird that it looks like Jenkins didn't build the PR but the master branch

@anmolnar do you have any clue ?

eolivelli · 2020-09-17T11:44:27Z

sing credential 683f5dcf-5552-4b28-9fb1-6a6b77cf53dd

Cloning the remote Git repository

Cloning with configured refspecs honoured and without tags

Cloning repository https://github.com/apache/zookeeper.git

 > git init /home/jenkins/jenkins-home/workspace/eper-precommit-github-pr_PR-1459 # timeout=10

Fetching upstream changes from https://github.com/apache/zookeeper.git

 > git --version # timeout=10

using GIT_ASKPASS to set credentials ASF Cloudbees Jenkins ci-hadoop

 > git fetch --no-tags --progress -- https://github.com/apache/zookeeper.git +refs/pull/1459/head:refs/remotes/origin/PR-1459 +refs/heads/master:refs/remotes/origin/master # timeout=10

 > git config remote.origin.url https://github.com/apache/zookeeper.git # timeout=10

 > git config --add remote.origin.fetch +refs/pull/1459/head:refs/remotes/origin/PR-1459 # timeout=10

 > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master # timeout=10

Fetching without tags

Merging remotes/origin/master commit c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 into PR head commit d33e75c97b0bf6729f4c3a67416f1a201ad31824

Merge succeeded, producing d33e75c97b0bf6729f4c3a67416f1a201ad31824

Checking out Revision d33e75c97b0bf6729f4c3a67416f1a201ad31824 (PR-1459)

 > git config remote.origin.url https://github.com/apache/zookeeper.git # timeout=10

Fetching upstream changes from https://github.com/apache/zookeeper.git

using GIT_ASKPASS to set credentials ASF Cloudbees Jenkins ci-hadoop

 > git fetch --no-tags --progress -- https://github.com/apache/zookeeper.git +refs/pull/1459/head:refs/remotes/origin/PR-1459 +refs/heads/master:refs/remotes/origin/master # timeout=10

 > git config core.sparsecheckout # timeout=10

 > git checkout -f d33e75c97b0bf6729f4c3a67416f1a201ad31824 # timeout=10

 > git merge c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10

 > git rev-parse HEAD^{commit} # timeout=10

 > git config core.sparsecheckout # timeout=10

 > git checkout -f d33e75c97b0bf6729f4c3a67416f1a201ad31824 # timeout=10

Commit message: "ZOOKEEPER-3863: correct junit test timeout"

 > git rev-list --no-walk d33e75c97b0bf6729f4c3a67416f1a201ad31824 # timeout=10

eolivelli · 2020-09-17T11:45:28Z

Then jenkins checks out again current master !


[2020-09-17T11:36:02.742Z] No credentials specified

[2020-09-17T11:36:02.816Z] Fetching changes from the remote Git repository

[2020-09-17T11:36:02.805Z]  > git rev-parse --is-inside-work-tree # timeout=10

[2020-09-17T11:36:02.879Z]  > git config remote.origin.url https://github.com/apache/zookeeper # timeout=10

[2020-09-17T11:36:02.953Z] Fetching upstream changes from https://github.com/apache/zookeeper

[2020-09-17T11:36:02.953Z]  > git --version # timeout=10

[2020-09-17T11:36:02.957Z]  > git fetch --tags --progress -- https://github.com/apache/zookeeper +refs/heads/*:refs/remotes/origin/* # timeout=10

[2020-09-17T11:36:10.782Z]  > git rev-parse refs/remotes/origin/master^{commit} # timeout=10

[2020-09-17T11:36:10.870Z] Checking out Revision c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 (refs/remotes/origin/master)

[2020-09-17T11:36:11.158Z] Commit message: "ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer"

[2020-09-17T11:36:10.856Z]  > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10

[2020-09-17T11:36:10.999Z]  > git config core.sparsecheckout # timeout=10

[2020-09-17T11:36:11.003Z]  > git checkout -f c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10

[2020-09-17T11:36:11.033Z]  > git branch -a -v --no-abbrev # timeout=10

[2020-09-17T11:36:11.044Z]  > git checkout -b master c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10

[2020-09-17T11:36:11.221Z]  > git rev-list --no-walk c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10

LiYvbo · 2020-09-17T11:48:13Z

Then jenkins checks out again current master !


[2020-09-17T11:36:02.742Z] No credentials specified

[2020-09-17T11:36:02.816Z] Fetching changes from the remote Git repository

[2020-09-17T11:36:02.805Z]  > git rev-parse --is-inside-work-tree # timeout=10

[2020-09-17T11:36:02.879Z]  > git config remote.origin.url https://github.com/apache/zookeeper # timeout=10

[2020-09-17T11:36:02.953Z] Fetching upstream changes from https://github.com/apache/zookeeper

[2020-09-17T11:36:02.953Z]  > git --version # timeout=10

[2020-09-17T11:36:02.957Z]  > git fetch --tags --progress -- https://github.com/apache/zookeeper +refs/heads/*:refs/remotes/origin/* # timeout=10

[2020-09-17T11:36:10.782Z]  > git rev-parse refs/remotes/origin/master^{commit} # timeout=10

[2020-09-17T11:36:10.870Z] Checking out Revision c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 (refs/remotes/origin/master)

[2020-09-17T11:36:11.158Z] Commit message: "ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer"

[2020-09-17T11:36:10.856Z]  > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10

[2020-09-17T11:36:10.999Z]  > git config core.sparsecheckout # timeout=10

[2020-09-17T11:36:11.003Z]  > git checkout -f c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10

[2020-09-17T11:36:11.033Z]  > git branch -a -v --no-abbrev # timeout=10

[2020-09-17T11:36:11.044Z]  > git checkout -b master c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10

[2020-09-17T11:36:11.221Z]  > git rev-list --no-walk c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10

can you please restart CI check for me in this PR? The failure was caused by the same reason.. @eolivelli

#1458

eolivelli · 2020-09-17T11:50:48Z

Yes,
here it is a proposal of fix
#1460

I have sent an email message to [email protected]

LiYvbo · 2020-09-17T12:16:14Z

Yes,
here it is a proposal of fix
#1460

I have sent an email message to [email protected]

Thanks! @eolivelli
After building, please make a review for PR #1458. It is the same with PR #1454. I add a Jira for this PR1458 to track the improvement.

LiYvbo eolivelli Author: tison <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1459 from TisonKun/patch-2

ZOOKEEPER-3863: correct junit test timeout

d33e75c

tisonkun force-pushed the patch-2 branch from 9039fb8 to d33e75c Compare September 17, 2020 10:51

tisonkun changed the title ~~hotfix: correct junit test timeout~~ ZOOKEEPER-3863: correct junit test timeout Sep 17, 2020

eolivelli closed this in 63f744b Sep 17, 2020

tisonkun deleted the patch-2 branch September 17, 2020 12:50

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022

ZOOKEEPER-3863: correct junit test timeout

57c5287

LiYvbo eolivelli Author: tison <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1459 from TisonKun/patch-2

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022

ZOOKEEPER-3863: correct junit test timeout

f19dfd5

LiYvbo eolivelli Author: tison <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1459 from TisonKun/patch-2

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022

ZOOKEEPER-3863: correct junit test timeout

d88fb5b

LiYvbo eolivelli Author: tison <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1459 from TisonKun/patch-2

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022

ZOOKEEPER-3863: correct junit test timeout

98c992c

LiYvbo eolivelli Author: tison <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1459 from TisonKun/patch-2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZOOKEEPER-3863: correct junit test timeout #1459

ZOOKEEPER-3863: correct junit test timeout #1459

tisonkun commented Sep 17, 2020

tisonkun commented Sep 17, 2020 •

edited

Loading

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

tisonkun commented Sep 17, 2020

tisonkun commented Sep 17, 2020

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

LiYvbo commented Sep 17, 2020 •

edited

Loading

eolivelli commented Sep 17, 2020

LiYvbo commented Sep 17, 2020

ZOOKEEPER-3863: correct junit test timeout #1459

ZOOKEEPER-3863: correct junit test timeout #1459

Conversation

tisonkun commented Sep 17, 2020

tisonkun commented Sep 17, 2020 • edited Loading

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

tisonkun commented Sep 17, 2020

tisonkun commented Sep 17, 2020

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

eolivelli commented Sep 17, 2020

LiYvbo commented Sep 17, 2020 • edited Loading

eolivelli commented Sep 17, 2020

LiYvbo commented Sep 17, 2020

tisonkun commented Sep 17, 2020 •

edited

Loading

LiYvbo commented Sep 17, 2020 •

edited

Loading