ZOOKEEPER-4287: Upgrade prometheus client library version to 0.10.0 #1688
Conversation
| count[0]++; | ||
| int value = ((Number) v).intValue(); | ||
| switch (k) { | ||
| case "cc_total": |
There was a problem hiding this comment.
so with this upgrade we are changing the metrics that we are providing ?
can you please explain in the description of the PR and/or in JIRA ?
this may be a significant impact for people who created downstream processing dashboards/alerts
There was a problem hiding this comment.
Yes, Prometheus switched to OpenMetrics data model in 0.10.0 release. These means the following.
- all Counter samples now have a _total suffix
- Counter, Summary, and Histogram metrics now expose a _created sample with when their child was created
More details can be found in the Prometheus change logs https://github.com/prometheus/client_java/releases
Yes, the downstream processing dashboard/alerts need to make the change accordingly when they upgrade ZK version.
|
Please conclude this PR, if this is supposed to be part of 3.7.1 release |
|
I think that we can include this change in 3.9.0 |
-- Upgrade the prometheus simple-client version from 0.9.0 to 0.10.0, which is the latest。
-- Prometheus switched to OpenMetrics data model in the 0.10.0 release. These means the downstream dashboard/alert may be impacted because