fix: symfony deprecations #7277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentLanglet
commented
Jul 3, 2025
VincentLanglet
commented
| Q | A |
|---|---|
| Branch? | main for features / current stable version branch for bug fixes |
| Tickets | Closes #..., closes #... |
| License | MIT |
| Doc PR | api-platform/docs#... |
VincentLanglet
force-pushed
the
solve-deprecations
branch
from
368e6bd to
362c0f1
Compare
VincentLanglet
commented
Jul 3, 2025
| @@ -23,7 +23,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=8.2", | |||
| "api-platform/metadata": "^4.1.11", | |||
| "api-platform/metadata": "^4.1.16", | |||
There was a problem hiding this comment.
The AccessDeniedException was introduced in 4.1.16.
b2b5f99
| @@ -541,7 +545,6 @@ public function withNativeType(?Type $nativeType): self | |||
| { | |||
| $self = clone $this; | |||
| $self->nativeType = $nativeType; | |||
| $self->builtinTypes = PropertyInfoToTypeInfoHelper::convertTypeToLegacyTypes($nativeType) ?? []; | |||
There was a problem hiding this comment.
Using withNativeType was triggering the symfony deprecation.
Instead we should hydrate the buildinTypes only if necessary, which means, only if getBuildinTypes is called.
This solve the deprecations.
| @@ -46,7 +46,11 @@ public function testSupports(Constraint $constraint, ApiProperty $propertyMetada | |||
| public static function supportsProvider(): \Generator | |||
| { | |||
| yield 'email' => [new Email(), new ApiProperty(), true]; | |||
| yield 'url' => [new Url(), new ApiProperty(), true]; | |||
| if (property_exists(Url::class, 'requireTld')) { | |||
| yield 'url' => [new Url(requireTld: true), new ApiProperty(), true]; | |||
There was a problem hiding this comment.
Not passing requireTld imply a deprecation for sf > 7.1 ; but the property only exists since 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.