-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade apollo version to 2.4.0 #21
Conversation
WalkthroughThis pull request updates the version information for the apollo-portal and apollo-service Helm charts. In both Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/index.yaml (2)
3-307
: Consistent Update of 'created' Timestamps in Apollo-Portal Entries
Multiple entries under the apollo-portal key have updatedcreated
timestamps (e.g., lines 6, 22, 38, 54, 70, … up to line 307). This appears to be the result of regenerating the index file.
Please verify that these timestamps accurately represent the timing of the release and that the time zone or formatting meets your expectations.
325-612
: Consistent Update of 'created' Timestamps in Apollo-Service Entries
Similarly, many entries for apollo-service (after the new entry) show updatedcreated
timestamps (for example, lines 327, 343, 359, 375, … up to line 612).
Ensure these updates are intentional and consistent with your CI/CD pipeline’s timestamp generation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apollo-portal/Chart.yaml
(1 hunks)apollo-service/Chart.yaml
(1 hunks)docs/index.yaml
(37 hunks)
✅ Files skipped from review due to trivial changes (2)
- apollo-service/Chart.yaml
- apollo-portal/Chart.yaml
🔇 Additional comments (3)
docs/index.yaml (3)
4-19
: New Apollo-Portal Entry with Upgraded Version
This new top entry for apollo-portal now reflects the updated release details:
appVersion
is updated to 2.4.0 (in line with the PR objective)version
is updated to 0.10.0- The
created
timestamp is newly set to a current value.Everything in this block appears consistent with the intended upgrade. Please verify that all Helm chart metadata for apollo-portal has been updated accordingly.
308-324
: New Apollo-Service Chart Entry Added
A new entry for apollo-service has been introduced with the following details:
appVersion
is set to 2.4.0version
is set to 0.10.0- Associated metadata (including
created
,description
,digest
, etc.) is provided.This addition meets the upgrade objective. Please ensure that the corresponding Helm chart files also reflect these changes.
613-614
: Verify Generation Timestamp
The finalgenerated
field (line 613) is now set to"2025-02-10T21:10:58.941731+08:00"
. Please confirm that this generation timestamp correctly reflects the current build process.
Summary by CodeRabbit