[SA-25286] Use Non-Deprecated Status Endpoint #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
ravenc-appgate
requested review from
mandopaloooza,
rafaelosoto,
hydrolucid,
RicardoRamirezG and
torgermiller
Comment on lines
-127
to
-154
| for _, f := range functions { | ||
| switch f { | ||
| case FunctionController: | ||
| count := cts.Stats.GetControllerCount() + 1 | ||
| cts.Stats.SetControllerCount(count) | ||
| cts.UpgradedStats.SetControllerCount(count) | ||
| case FunctionGateway: | ||
| count := cts.Stats.GetGatewayCount() + 1 | ||
| cts.Stats.SetGatewayCount(count) | ||
| cts.UpgradedStats.SetGatewayCount(count) | ||
| case FunctionLogServer: | ||
| count := cts.Stats.GetLogServerCount() + 1 | ||
| cts.Stats.SetLogServerCount(count) | ||
| cts.UpgradedStats.SetLogServerCount(count) | ||
| case FunctionLogForwarder: | ||
| count := cts.Stats.GetLogForwarderCount() + 1 | ||
| cts.Stats.SetLogForwarderCount(count) | ||
| cts.UpgradedStats.SetLogForwarderCount(count) | ||
| case FunctionPortal: | ||
| count := cts.Stats.GetPortalCount() + 1 | ||
| cts.Stats.SetPortalCount(count) | ||
| cts.UpgradedStats.SetPortalCount(count) | ||
| case FunctionConnector: | ||
| count := cts.Stats.GetConnectorCount() + 1 | ||
| cts.Stats.SetConnectorCount(count) | ||
| cts.UpgradedStats.SetConnectorCount(count) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this part captured in another field like .Stats.Data and .UpgradeStats.Data?
There was a problem hiding this comment.
I don't believe so. I didn't see these fields in the new API spec.
Comment on lines
-608
to
+612
| c8, s8, _ := GenerateApplianceWithStats([]string{FunctionController}, "controller8", "", "6.2.0", "", statusHealthy, UpgradeStatusIdle, false, "default", "default") | ||
| c8, s8, _ := GenerateApplianceWithStats([]string{FunctionController}, "controller8", "", "6.2.0", "", statusOffline, UpgradeStatusIdle, false, "default", "default") |
There was a problem hiding this comment.
Huh I guess the test was wrong lol.
Comment on lines
-62
to
+70
| Name: openapi.PtrString("controller"), | ||
| Disk: openapi.PtrFloat32(90), | ||
| Version: openapi.PtrString("5.5.4"), | ||
| DiskInfo: &openapi.StatsAppliancesListAllOfDiskInfo{ | ||
| Total: openapi.PtrFloat32(100000000000), | ||
| Used: openapi.PtrFloat32(90000000000), | ||
| Free: openapi.PtrFloat32(10000000000), | ||
| Name: "controller", | ||
| Disk: openapi.PtrFloat32(90), | ||
| ApplianceVersion: openapi.PtrString("5.5.4"), | ||
| Details: &openapi.ApplianceWithStatusAllOfDetails{ | ||
| Disk: &openapi.SystemInfo{ | ||
| Total: openapi.PtrInt64(int64(100000000000)), | ||
| Used: openapi.PtrInt64(int64(90000000000)), | ||
| Free: openapi.PtrInt64(int64(10000000000)), | ||
| }, |
There was a problem hiding this comment.
I think this is the original issue in the API spec where you wanted int64 which led you to this journey of tasks. Thanks for taking this on! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.