Make EventLoopFuture/Promise conditionally Sendable
#2113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
commented
May 13, 2022
| @@ -98,7 +98,7 @@ extension Channel { | |||
| /// Get the value of `option` for this `Channel`. | |||
| @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) | |||
| @inlinable | |||
| public func getOption<Option: ChannelOption>(_ option: Option) async throws -> Option.Value { | |||
| public func getOption<Option: ChannelOption>(_ option: Option) async throws -> Option.Value where Option.Value: Sendable { | |||
There was a problem hiding this comment.
ChannelOption.Value should be Sendable but currently we can't do so in source stable way #2108
dnadoba
commented
May 13, 2022
|
|
||
| #if swift(>=5.5) && canImport(_Concurrency) | ||
| @usableFromInline | ||
| internal struct UncheckedSendable<Value>: @unchecked Sendable { |
There was a problem hiding this comment.
only used in deprecated methods to silence warnings
and `.get()` only available if `Value` is `Sendable`. Also fix warnings because of that change.
dnadoba
force-pushed
the
dn-sendable-future-promise-conditionally
branch
from
71522d1 to
8aa859e
Compare
|
These are now unilaterally Sendable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
.get()only available ifValueisSendable:Also fix warnings because of these changes.
Normally this is a source-breaking change. However,
Sendableis special and it looks like it may be a API stable change.