chore: Revert "test: Git integration tests (#38237)"

[nidhi-nair]

This reverts commit e45cbdf.

Unblocking CI to manage EE separately.

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling in branch deletion functionality to maintain file lock integrity during operations.

• New Features

  • Removed functionality for setting artifact names through the ArtifactCE interface.

• Chores

  • Removed multiple test classes and utilities related to Git workflows, streamlining the testing framework.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves the removal of several test utility classes and interfaces related to Git artifact testing in the Appsmith server project. The changes primarily focus on eliminating test infrastructure components, including context providers, builder extensions, and utility classes that were used for managing Git-related test scenarios. Additionally, there's a modification to the ArtifactCE interface, specifically removing the setName method.

Changes

File Path	Change Summary
app/server/appsmith-server/src/main/java/com/appsmith/server/domains/ce/ArtifactCE.java	Removed setName(String artifactName) method
app/server/appsmith-server/src/test/it/com/appsmith/server/git/...	Removed multiple test-related classes: - GitBranchesIT.java - GitContext.java - GitBranchesTestTemplateProvider.java - GitBranchesTestTemplateProviderCE.java
app/server/appsmith-server/src/test/utils/com/appsmith/server/git/...	Removed utility classes: - ArtifactBuilderContext.java - ArtifactBuilderExtension.java - GitArtifactTestUtils.java - GitServerInitializerExtension.java - GitTestUtils.java

Possibly related PRs

• test: Git integration tests #38237: The addition of the setName(String artifactName) method in the ArtifactCE interface is directly related to the main PR, which removed the same method from the ArtifactCE interface. This indicates a change in how artifact names are managed within the application.
• feat: added commit changes #37922: The changes in the GitRedisUtils class, particularly the modifications to the addFileLock method, are relevant as they involve the management of file locks, which could be impacted by the removal of the setName method in the context of artifact handling.
• chore: added status changes #38170: The introduction of new methods related to Git status management in the CentralGitServiceCE interface and its implementation may relate to the overall management of artifacts and their states, which is affected by the changes in the ArtifactCE interface.
• chore: pr for delete references #38210: The addition of the deleteGitReference method in the CentralGitServiceCE interface is relevant as it expands the functionality related to Git references, which may be impacted by changes in artifact management.
• chore: reference lifecycle #38174: The modifications to the GitArtifactMetadataCE class, including the addition of a refType field, are relevant as they pertain to the metadata associated with artifacts, which is directly related to the changes in the ArtifactCE interface.

Suggested Labels

ok-to-test

Suggested Reviewers

• nidhi-nair

Poem

🌿 Git's test tools, now laid to rest,

Code cleanup, passing every test

Artifacts stripped, utilities gone

A cleaner codebase has just been drawn!

🧹✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5855115 and 6ac7e89.

📒 Files selected for processing (11)

• app/server/appsmith-server/src/main/java/com/appsmith/server/domains/ce/ArtifactCE.java (0 hunks)
• app/server/appsmith-server/src/main/java/com/appsmith/server/git/common/CommonGitServiceCEImpl.java (1 hunks)
• app/server/appsmith-server/src/test/it/com/appsmith/server/git/GitBranchesIT.java (0 hunks)
• app/server/appsmith-server/src/test/it/com/appsmith/server/git/templates/contexts/GitContext.java (0 hunks)
• app/server/appsmith-server/src/test/it/com/appsmith/server/git/templates/providers/GitBranchesTestTemplateProvider.java (0 hunks)
• app/server/appsmith-server/src/test/it/com/appsmith/server/git/templates/providers/ce/GitBranchesTestTemplateProviderCE.java (0 hunks)
• app/server/appsmith-server/src/test/utils/com/appsmith/server/git/ArtifactBuilderContext.java (0 hunks)
• app/server/appsmith-server/src/test/utils/com/appsmith/server/git/ArtifactBuilderExtension.java (0 hunks)
• app/server/appsmith-server/src/test/utils/com/appsmith/server/git/GitArtifactTestUtils.java (0 hunks)
• app/server/appsmith-server/src/test/utils/com/appsmith/server/git/GitServerInitializerExtension.java (0 hunks)
• app/server/appsmith-server/src/test/utils/com/appsmith/server/git/GitTestUtils.java (0 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.