Skip to content

Commit

Permalink
test(agent/reaper): Fix restructure issue (coder#7168)
Browse files Browse the repository at this point in the history
In coder#7164 we accidentally removed the "in CI" check, this fixes it.
  • Loading branch information
mafredri authored Apr 17, 2023
1 parent bb3b8ba commit b3b26a6
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions agent/reaper/reaper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ import (
"github.com/coder/coder/testutil"
)

//nolint:paralleltest // Non-parallel subtest.
// TestReap checks that's the reaper is successfully reaping
// exited processes and passing the PIDs through the shared
// channel.
//
//nolint:paralleltest
func TestReap(t *testing.T) {
// Don't run the reaper test in CI. It does weird
// things like forkexecing which may have unintended
Expand All @@ -27,13 +31,6 @@ func TestReap(t *testing.T) {
t.Skip("Detected CI, skipping reaper tests")
}

// OK checks that's the reaper is successfully reaping
// exited processes and passing the PIDs through the shared
// channel.
}

//nolint:paralleltest // Signal handling.
func TestReap_OK(t *testing.T) {
pids := make(reap.PidCh, 1)
err := reaper.ForkReap(
reaper.WithPIDCallback(pids),
Expand Down

0 comments on commit b3b26a6

Please sign in to comment.