Use correct set of flags for Symbol.newBind in ZippedProduct
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this ❤️ |
|
ducktape 0.1.11 is being published as we speak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 3.3.1 would introduce additional checks under
-Xcheck-macrosflags, one of these are validating correct usage ofFlagsforSymbol.newBind. scala/scala3@3c3c0fbCurrently used
Flags.Localsare incorrect as they should be used forSymbol.newVal.Symbol.newBindrequires subset ofFlags.Case. The issue was found in the Open Community Build for Scala 3.3.1-RC5 and the logs can be found hereI propose a quick fix for these issue, and I recommend to publish a new patch version of ducktape before release 3.3.1 to allow for frictionless migration of ducktape users to newer version of compiler and to allow the Open Community Build to test this project against next versions of the compiler