Refactor edge cursor for dbserver #21928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trieval-single-server-case
- add a use-cache plug to SingleServerNeighbourProvider because for some usages - e.g. a simple tree traversal - the cache will not be useful and just waste memory. The plug is not yet used. - reverse batch size memory batch for batch vector for more efficient memory usage - get batch size from ExecutionBlock::DefaultBatchSize instead of using a "magic number"
…our-retrieval-single-server-case
…our-retrieval-single-server-case
…our-retrieval-single-server-case
Get rid of 'refactored'
|
TODO merge parent first |
jvolmer
force-pushed
the
feature/refactor-dbserver-edge-cursor
branch
from
949a843 to
ba81e8e
Compare
We don't need nested vector of cursors, simple vector is enough
Base automatically changed from
feature/batch-neighbour-retrieval-single-server-case
to
devel
August 28, 2025 09:57
…erver-edge-cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enterprise branch that needs to be merged together: https://github.com/arangodb/enterprise/pull/1540
This refactoring improves on the testability of the edge cursor for a dbserver because we want to add new functionality there. It basically separates the dbserver index cursor (a cursor for one index on one collection / shard) from the dbserver edge cursor (a collection of dbserver index cursors: there can be several collections / shards and each one of them can have several index cursors). Now the dbserver edge cursor can be properly unit tested because all the server related stuff is extracted into dbserver index cursor.
Additionally, I renamed: SingleServerEdgeCursor to DBServerEdgeCursor and RefactoredSingleServerEdgeCursor to SingleServerEdgeCursor.