chore: upgrade k8s modules to suport v1.29 #455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asdfgugus <[email protected]>
asdfgugus
force-pushed
the
chore/client-go
branch
from
7227669
to
244b07c
Compare
the-technat
reviewed
Oct 10, 2024
There was a problem hiding this comment.
The linter config has to be updated if we bump to go 1.22 (see failed test).
But anyway, can we wait with this til #443 is merged? I'm not sure how these PR's relate to each other, maybe they need to go together for successful builds.
|
Sounds good. Anyways, I have to invest more time to upgrade the modules. If you find the time, feel free to upgrade it yourself. |
|
Maybe we can include update-script (hack) from the upstream argo-cd repo: Xref: |
mkilchhofer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.