-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus #21937
base: master
Are you sure you want to change the base?
chore: use github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus #21937
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
I followed examples/server . I'm probably going to need some help to make integration tests pass |
05563b0
to
ee12c3c
Compare
Hi @bwplotka, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21937 +/- ##
==========================================
+ Coverage 55.63% 55.73% +0.10%
==========================================
Files 341 341
Lines 56996 57011 +15
==========================================
+ Hits 31708 31776 +68
+ Misses 22634 22599 -35
+ Partials 2654 2636 -18 ☔ View full report in Codecov by Sentry. |
…metheus Signed-off-by: Matthieu MOREL <[email protected]>
ee12c3c
to
48abaf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
github.com/grpc-ecosystem/go-grpc-prometheus
is archived since April 18, 2023 and is replaced bygithub.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus
.