Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scrolling with keyboard opened #105

Conversation

jakubkrolewski
Copy link

This PR purpose is providing the fix for #34.
The keyboard stays opened during suggestions scrolling on tablets and on phones in portrait mode. It's closed on phones in landscape mode.
This PR contains as well:

  • demo adjustments to test this functionality
  • fix for making suggestions visible also in landscape mode
  • some code improvements

@arimorty
Copy link
Owner

arimorty commented Aug 9, 2016

Hi @jakubkrolewski ,

I am looking at your PR, and it's very big. It looks like you have added and organized a lot of stuff so I can't pull everything in right away. I need to review every change and see if it fits with the focus of this library. It would be better (and much easier for me) if PRs are more focused at solving/adding one thing, there is nothing wrong about requesting multiple PRs for different issues or improvements.

From a brief review of your code, it looks like you added some stuff that I would definitely want to merge into the library, but again, it's very high risk to pull in such a large PR at once.

What you can do is to close this PR and re-submit more cohesive PRs for each problem/improvement. For example, cleaning up code would be one, adding a feature (in your case the scrolling with keyboard opened that I am very interested in btw), etc. It's not a burden for me if you add as many PRs as you feel you need.

Many thanks for contributing,
Ari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants