Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Added the test case to verify the Graceful Restart (GR) and GR-Helper #988

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

geetanjalimanegslab
Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab commented Dec 26, 2024

Description

This test performs the following checks:
1. Verifies that the ISIS is configured.
3. Verifies that the specified ISIS instance is found.
4. Verifies that the IS-IS graceful restart and graceful helper are set as expected in the inputs.

Expected Results

  • Success: The test will pass if all of the following conditions are met:
    • The ISIS is configured on the device.
    • The specified ISIS instance is found
    • The expected and actual IS-IS graceful restart and graceful helper values are matched.
  • Failure: The test will fail if any of the following conditions is met:
    • The ISIS is not configured on the device.
    • The specified ISIS instance is not found.
    • The Expected and actual IS-IS graceful restart and graceful helper values are not matched.

Fixes #882

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Dec 26, 2024

CodSpeed Performance Report

Merging #988 will not alter performance

Comparing geetanjalimanegslab:test_isis_graceful_restart (44ed38a) with main (1f033f4)

Summary

✅ 22 untouched benchmarks

anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/input_models/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Outdated Show resolved Hide resolved
anta/tests/routing/isis.py Show resolved Hide resolved
@gmuloc gmuloc added this to the v1.3.0 milestone Jan 2, 2025
@geetanjalimanegslab geetanjalimanegslab force-pushed the test_isis_graceful_restart branch from 9b6edec to 43516d8 Compare January 3, 2025 14:14
@vitthalmagadum vitthalmagadum marked this pull request as ready for review January 7, 2025 10:04
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until #963 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the test case to verify the Graceful Restart (GR) and GR-Helper
4 participants