Improve how we use git in eext and improve the code's testing facilities. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of the function was missing, and the comment grammar implied that only the pull is being done.
There was a lot of boiler plate that was hard to follow, so this patch introduces a simple list of git commands to run. It should also yield potentially better error messages in case of a failure.
mkisielewski-arista
force-pushed
the
mkisielewski-improve-git-shenanigans
branch
from
4a3212b to
7f5bb57
Compare
| "code.arista.io/eos/tools/eext/util" | ||
| "github.com/spf13/viper" | ||
| "github.com/stretchr/testify/require" | ||
| //"code.arista.io/eos/tools/eext/executor/mocked_executor" |
There was a problem hiding this comment.
Comment can be removed
| // MockedExecutor returns the Response objects for each of the MockedExecutor | ||
| // calls. The responses are consumed in the natural order, meaning [0] is the | ||
| // first one to be returned. | ||
| Responses []Response |
There was a problem hiding this comment.
Should we consider making this a struct of Call and Response.
type MockedExecutor struct {
MockedEntries []struct{
Response Response
Call RecordedCall
}
}
Currently the onus of maintaining the order of Response is on the dev, and I feel the mapping might get messier with longer Response slices.
| if err != nil { | ||
| t.Fatal(err) | ||
| mex := executor.MockedExecutor{ | ||
| Responses: []executor.Response{executor.NewResponse(0, "libpcap-1.10.1", nil)}, |
There was a problem hiding this comment.
This Response is the mocked output for the call
rpmName, err := executor.Output("rpmspec", cmd...)
within the getRpmNameFromSpecFile().
But that isn't evident here.
Furthermore a reason to have a struct of Call and Response for easier readability.
| @@ -15,7 +15,7 @@ type DryRunExecutor struct { | |||
| // extra abstractions feel unnecessary. | |||
|
|
|||
| // human friendly description of what an invocation would do | |||
| invocations []string | |||
| Invocations []string | |||
There was a problem hiding this comment.
We aren't using this member outside this file. Do we need to export it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests for code that sourced packages with git was downloading actual repositories. This PR rearranges the code a bit to make it more testable, introduces a simple executor mock, and uses it, making the whole process more contained.
It also has a small fix (97b67a2) that properly handles commits used as revisions. The new tests also cover this logic path.