Skip to content

Commit

Permalink
chore(sample-modules): audit deps (americanexpress#509)
Browse files Browse the repository at this point in the history
  • Loading branch information
JAdshead authored May 11, 2021
1 parent f04360d commit 21ffb05
Show file tree
Hide file tree
Showing 42 changed files with 10,226 additions and 6,794 deletions.
15 changes: 9 additions & 6 deletions __tests__/integration/one-app.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -738,23 +738,26 @@ describe('Tests that require Docker setup', () => {
describe('child module `requiredExternals` valid usage', () => {
const providedExternalsModuleValidation = /Module late-frank attempted to provide externals/;

const moduleName = 'late-frank';
const version = '0.0.2';

let providedExternalsWarning;

beforeAll(async () => {
providedExternalsWarning = searchForNextLogMatch(providedExternalsModuleValidation);
await addModuleToModuleMap({
moduleName,
version,
moduleName: 'frank-lloyd-root',
version: '0.0.2',
});
await addModuleToModuleMap({
moduleName: 'late-frank',
version: '0.0.2',
});
// not ideal but need to wait for app to poll;
await waitFor(5000);
});

afterAll(() => {
afterAll(async () => {
writeModuleMap(originalModuleMap);
// not ideal but need to wait for app to poll;
await waitFor(5000);
});

test('does not write a warning to log if a child module is configured with `requiredExternals`', async () => {
Expand Down
214 changes: 107 additions & 107 deletions prod-sample/api/package-lock.json

Large diffs are not rendered by default.

298 changes: 143 additions & 155 deletions prod-sample/sample-modules/cultured-frankie/0.0.0/package-lock.json

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions prod-sample/sample-modules/cultured-frankie/0.0.0/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
"prepare": "npm run build"
},
"dependencies": {
"@americanexpress/one-app-ducks": "^4.0.0",
"holocron": "^1.1.0",
"@americanexpress/one-app-ducks": "^4.3.2",
"holocron": "^1.1.4",
"immutable": "^3.8.2",
"prop-types": "^15.5.9",
"react": "^16.4.2",
"react-intl": "^3.6.0",
"react-redux": "^7.1.3",
"redux": "^4.0.4"
"react": "^16.14.0",
"react-intl": "^3.12.1",
"react-redux": "^7.2.4",
"redux": "^4.1.0"
},
"devDependencies": {
"@americanexpress/one-app-bundler": "^6.12.0",
Expand Down
Loading

0 comments on commit 21ffb05

Please sign in to comment.