Initial purity plugin #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
reviewed
Nov 10, 2019
| LocalInspectionTool::class.java | ||
| )*/ | ||
| val ArrowPath: Array<String> | ||
| get() = arrayOf("Kotlin", "Λrrow") |
There was a problem hiding this comment.
Suggested change
| get() = arrayOf("Kotlin", "Λrrow") | |
| arrayOf("Kotlin", "Λrrow") |
raulraja
reviewed
Nov 10, 2019
| ) | ||
| ) | ||
| } | ||
| get() = TODO() |
There was a problem hiding this comment.
We should probably remove the whole file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve #28
The
InspectionSyntaxallows us to write costume Inspections based on Tooling, what Kotlin already uses in the editor. This allows plugin developers to not only indicate code elements, which need to be inspected but additionally to manipulate them programmatically.As here to add a
suspendedkeyword to a function.ApplicableInspectionscan traverse any KtElement. Furthermore, we can extend the Scope of Inspection to the whole Project instead of individual files. This allows users to write fast fixes, which are universal for the whole project and deal with subsequent issues.I'll add checks for calls in the function body, which return Unit or Nothing.
We should also add Text for an explanation.