Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for FPR event detail commands #2024

Merged
merged 9 commits into from
Feb 21, 2025

Conversation

replaceafill
Copy link
Member

@replaceafill replaceafill commented Feb 20, 2025

This adds tests that assert the output of the existing event detail commands in the FPR.

The tests assume the MCPClient OS tools are installed in the test runner and call archivematicaCommon's executeOrRun to execute the event detail commands.

A couple of notes about the implementation:

  • The unrar-nonfree parameter is skipped at the moment because we don't install that package in the development environment or in the Ansible role. We should probably update the event detail command to use the unrar command instead.
  • I have added a data migration to update event detail commands. For now it only updates the Get event detail text for 7z extraction command to be compatible with newer versions of 7z, but as I stated in the previous point we might need to update the unrar-nonfree command as well (to be decided).
  • The regular expression patterns used to match the version="..." part of the output are not strict and they only look at the beginning of lines.

Connected to archivematica/Issues#1729

Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@replaceafill replaceafill merged commit b79e221 into qa/1.x Feb 21, 2025
22 checks passed
@replaceafill replaceafill deleted the dev/issue-1729-test-fpr-event-detail-commands branch February 21, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants