Add tests for FPR event detail commands #2024
Merged
+200
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests that assert the output of the existing event detail commands in the FPR.
The tests assume the MCPClient OS tools are installed in the test runner and call
archivematicaCommon
'sexecuteOrRun
to execute the event detail commands.A couple of notes about the implementation:
unrar-nonfree
parameter is skipped at the moment because we don't install that package in the development environment or in the Ansible role. We should probably update the event detail command to use theunrar
command instead.Get event detail text for 7z extraction
command to be compatible with newer versions of7z
, but as I stated in the previous point we might need to update theunrar-nonfree
command as well (to be decided).version="..."
part of the output are not strict and they only look at the beginning of lines.Connected to archivematica/Issues#1729