fix: Ignore bases outside the reference #113
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug we bumped into, where reads that map partially beyond the end of the reference cause
artic minion
to crash.The problem arises because the size of the vector
depths
inmake_depth_mask.py
is equal to the length of the reference. When callingbamFile.pileup(...)
, however,pileupcolumn.pos
might cause anIndex out of range
error if there is a read that goes beyond the end of the reference or before its start position.Since these sections of the reads are irrelevant to calculate coverage, the solution implemented here is to set boundaries for the
bamFile.pileup(...)
function, so that it only considers bases within the reference.