forked from rerun-io/rerun
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename
LeafTransforms3D
to InstancePoses3D
, disable implicit empt…
…y component logging for it (rerun-io#7143) ### What * Fixes rerun-io#7126 * rename * talk about 'mesh instancing' for the mesh instancing snippet * disable "log missing as empty" for `InstancePoses3D` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7143?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7143?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7143) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
- Loading branch information
Showing
112 changed files
with
1,000 additions
and
1,085 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
crates/store/re_types/definitions/rerun/archetypes/instance_poses3d.fbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
namespace rerun.archetypes; | ||
|
||
|
||
/// One or more transforms between the current entity and its parent. Unlike [archetypes.Transform3D], it is *not* propagated in the transform hierarchy. | ||
/// | ||
/// If both [archetypes.InstancePoses3D] and [archetypes.Transform3D] are present, | ||
/// first the tree propagating [archetypes.Transform3D] is applied, then [archetypes.InstancePoses3D]. | ||
/// | ||
/// Currently, many visualizers support only a single instance transform per entity. | ||
/// Check archetype documentations for details - if not otherwise specified, only the first instance transform is applied. | ||
/// | ||
/// From the point of view of the entity's coordinate system, | ||
/// all components are applied in the inverse order they are listed here. | ||
/// E.g. if both a translation and a max3x3 transform are present, | ||
/// the 3x3 matrix is applied first, followed by the translation. | ||
/// | ||
/// \example archetypes/instance_pose3d_combined title="Regular & instance transforms in tandem" image="https://static.rerun.io/leaf_transform3d/41674f0082d6de489f8a1cd1583f60f6b5820ddf/1200w.png" | ||
table InstancePoses3D ( | ||
"attr.docs.category": "Spatial 3D", | ||
"attr.docs.view_types": "Spatial3DView, Spatial2DView: if logged above active projection", | ||
"attr.rust.derive": " PartialEq", | ||
"attr.rust.generate_field_info" | ||
) { | ||
/// Translation vectors. | ||
translations: [rerun.components.PoseTranslation3D] ("attr.rerun.component_optional", nullable, order: 1100); | ||
|
||
/// Rotations via axis + angle. | ||
rotation_axis_angles: [rerun.components.PoseRotationAxisAngle] ("attr.rerun.component_optional", nullable, order: 1200); | ||
|
||
/// Rotations via quaternion. | ||
quaternions: [rerun.components.PoseRotationQuat] ("attr.rerun.component_optional", nullable, order: 1300); | ||
|
||
/// Scaling factors. | ||
scales: [rerun.components.PoseScale3D] ("attr.rerun.component_optional", nullable, order: 1400); | ||
|
||
/// 3x3 transformation matrices. | ||
mat3x3: [rerun.components.PoseTransformMat3x3] ("attr.rerun.component_optional", nullable, order: 1500); | ||
|
||
// TODO(andreas): Support TransformRelation? | ||
// TODO(andreas): Support axis_length? | ||
} |
48 changes: 0 additions & 48 deletions
48
crates/store/re_types/definitions/rerun/archetypes/leaf_transforms3d.fbs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.