chore(EMI-2439): add submittedOrder and submittedOffer events #15485
+120
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquartararo
changed the title
|
I just realized these test files will no longer be used for the new checkout redesign, so I'm not going to put effort into adding tests/refactoring. I will just fix the currently failing tests. |
erikdstock
approved these changes
Apr 24, 2025
Comment on lines
+180
to
+184
| const payload: SubmittedOffer = { | ||
| action: ActionType.submittedOffer, | ||
| context_page_owner_type: OwnerType.ordersShipping, | ||
| order_id: order.internalID ?? "", | ||
| flow: |
There was a problem hiding this comment.
non-blocking: Can any of these things be inherited from some page context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Chore
This PR solves EMI-2439
Description
Adds the
submittedOrderandsubmittedOfferevents to express checkout and non-express checkout flows from artsy/cohesion#586