Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: env variable for infinite discovery use internal tracking of seen artworks #6454

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

nickskalkin
Copy link
Contributor

Allows dynamically control behaviour of discoverArtworks endpoint—this should give us more flexibility when switching from storage-based tracking of seen artworks to backend-based tracking.

@nickskalkin nickskalkin merged commit 6a80523 into main Feb 24, 2025
4 checks passed
@nickskalkin nickskalkin deleted the nickskalkin/infinite-disco-ff-internal-tracking branch February 24, 2025 13:55
@egdbear
Copy link
Contributor

egdbear commented Feb 24, 2025

Do we need to introduce this interim environment variable for now, or can we just connect with the new seen artworks API?

@artsy-peril artsy-peril bot mentioned this pull request Feb 24, 2025
@nickskalkin
Copy link
Contributor Author

@egdbear I think it's worth introducing it (it costs nothing, but I will give us some control to switch between not-tested backend approach and the tested one). Once we have some confidence in the backend approach—we can get rid of it, as well as from use_internal_tracking param on Gravity side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants