chore: AMBER-1316 - artwork imports list page #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitch-Henson
commented
Feb 27, 2025
| @@ -163,6 +169,12 @@ export const ArtworkImportType = new GraphQLObjectType({ | |||
| }, | |||
| }), | |||
| resolve: async ({ id, currency }, args, { artworkImportRowsLoader }) => { | |||
| if (!artworkImportRowsLoader) { | |||
There was a problem hiding this comment.
Not sure how to get around this @mzikherman. Would love to hear your thoughts! Had to use thunk to get the date and this then caused the loader to potentially be undefined causing this code. I don't think this should ever happen because this is already authorized territory but couldn't fix this in another way.
mzikherman
approved these changes
Feb 27, 2025
| ...InternalIDFields, | ||
| columns: { | ||
| type: new GraphQLNonNull(GraphQLList(new GraphQLNonNull(GraphQLString))), | ||
| description: | ||
| "Columns to display for an import, will exist in a row's `transformedData`", | ||
| }, | ||
| createdAt: date(), | ||
| createdBy: { |
There was a problem hiding this comment.
This doesn't match the created_by in the Gravity PR - https://github.com/artsy/gravity/pull/18639 - where this is a User.
| @@ -163,6 +169,12 @@ export const ArtworkImportType = new GraphQLObjectType({ | |||
| }, | |||
| }), | |||
| resolve: async ({ id, currency }, args, { artworkImportRowsLoader }) => { | |||
| if (!artworkImportRowsLoader) { | |||
lidimayra
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to deal with the changes made in this Gravity PR
Thanks to pairing with @lidimayra to get this over the line