Python3 support #14
Merged
Python3 support #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since py3 forces us to be more explicit about unicode/bytes differences, this check is a bit more robust than exact equality
Return from generator instead of raising StopIteration Check list_tables without checking order
Python3 gives resource warnings when refs are dropped for files that haven't
been closed. This commit adds explicit management via a `.close()` method on
classes that manage raw files, and calls `.close()` to eliminate all resource
warnings from tests.
Context managers are pretty nice for handling this, but I didn't want to change
the code too much. But! Python has thought of everything, and there's a
`closing` utility from `contextlib` that enables this pattern for objects with
methods called `close`:
```python
from contextlib import closing
from cog.database import Cog
from cog import config
with closing(Cog(config=config)) as db:
db.create_namespace('suuup')
db.create_or_load_table('suuup', 'my_friends')
db.put(('a', '1'))
assert db.get('a') == (b'0', ('a', '1'))
```
|
thank you!! Appreciate this very much! @uniphil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I took a first stab at porting this library to python3 (#13). I've gotten it to a state where the tests pass without warnings (and still pass in python 2.7), but I haven't validated it on an existing codebase, since I was checking this out for a new project :)