Corrections of unhandled exceptions/illegal file contents and sizes related to some ''.scl'' and ''.kbm'' files #417
Conversation
…oProcessor::resetTuning()'' method
Meantime, 6 new commits were released in ''asb2m10/dexed:master, all of them are merged now.
|
Thanks for this PR. Any chance you get surgesynthteam_tuningui PR pushed on surge-synthesizer ? |
You are welcome, I am glad if you have found it useful. Yes, I wish to send a PR to @baconpaul at Surge Synthesizer Team, to accept my modifications. And, if they accepted, I wish to restore the references to the related submodul to |
|
I don’t see the pr. Can you link it here? |
|
And would be happy to upstream those changes. They look pretty good on a quick skim. on the dexed changes hasn’t juce::ScopedPtr gone out of style and now we use Std::unique instead? |
I have not initiated the PR yet, I am waiting for Pascal's answer, maybe he has some issues to address. But of course, I can provide a link to my temporary repoI: https://github.com/FulopNandor/surgesynthteam_tuningui. I am intending to send a PR to you at its present state - except if Pascal has some further advice.:-) |
Thank you for your notification! I am going to try out! |
|
Cool. Except for the readme change your changes to timing ui look spot on to me in a quick review. And I would happily merge them I can definitely imagine pascal preferring that too since the surge synthesizer git dep has multiple maintainers team structure etc and i would welcome the contribution! |
That is fine for now and thanks for adapting the unique_ptr. Once surgesynthteam_tuningui is merged on the surge repo, I will merge this PR. Thanks. |
|
Dear Pascal (@asb2m10) and Paul (@baconpaul), thank you for your help and patience! I have just sent a PR to Paul. |
.gitmodules
Outdated
| @@ -6,7 +6,7 @@ | |||
| url = https://github.com/surge-synthesizer/tuning-library.git | |||
| [submodule "libs/surgesynthteam_tuningui"] | |||
| path = libs/surgesynthteam_tuningui | |||
| url = https://github.com/surge-synthesizer/surgesynthteam_tuningui.git | |||
There was a problem hiding this comment.
Hi @FulopNandor , can you switch back the repo to surge-synthesizer ?
There was a problem hiding this comment.
Hi @asb2m10 and @baconpaul , I have switched back that,
There was a problem hiding this comment.
Great and I merged your change to that repo so you should update it to head in the submodules from surge
There was a problem hiding this comment.
Thank you very-very much! I am going to do that. Have a nice weekend!:-)
|
Cool. So glad this code is still getting used in dexed! Thanks for the contribution @FulopNandor |
|
Dear Pascal (@asb2m10) and Paul (@baconpaul), I am glad that you found my modifications useful and incorporated them into your works. |
Dear Pascal, do apply my pull request, please.
Its purpose is to handle errors that occur when certain ''.scl'' and/or ''.kbm'' files are opened, causing Dexed to crash.
Furthermore, it contains some minor modifications related to displaying the content of ''.scl''/''.kbm'' files in the ''Current Tuning'' dialog, and exported ''.csv'' files.
To achieve this, not only some source files of Dexed were modified, but the ''tuning-library'' repository has also been updated to the latest version. Additionally, a temporary repository from ''surgesynthteam_tuningui'' has been introduced
to contain the necessary modifications.
A more detailed description of the encountered errors and a their corrections can be found in the announcement .
Thank you!
(I apologize for the mistake, I meant to write ''Pascal'' instead of ''Paul''. Thank you for your understanding.)