api: Deprecate pod-name as endpoint id

This commit deprecates the `pod-name` lookup in the Cilium API and replaces it with a `cep-name` lookup instead. As with the previous change in this commit series, the `pod-name` may no longer uniquely identify an endpoint if a pod has multiple network attachments. `pod-name` will continue to work as an endpoint id for the endpoint of the primary network interface. This commit only changes the API definition. The new ID will be hooked up in a subsequent commit. Co-authored-by: Tobias Klauser <[email protected]> Signed-off-by: Tobias Klauser <[email protected]> Signed-off-by: Sebastian Wicki <[email protected]>
asbubam · Jul 28, 2023 · 6f86237 · 6f86237
1 parent c6b9811
commit 6f86237
Show file tree

Hide file tree

Showing 27 changed files with 78 additions and 52 deletions.
diff --git a/Documentation/spelling_wordlist.txt b/Documentation/spelling_wordlist.txt
@@ -178,6 +178,7 @@ cardinality
 cass
 cassandra
 cassandraparser
+cep
 certgen
 certmanager
 cgroup

diff --git a/api/v1/client/endpoint/delete_endpoint_id_parameters.go b/api/v1/client/endpoint/delete_endpoint_id_parameters.go
diff --git a/api/v1/client/endpoint/get_endpoint_id_config_parameters.go b/api/v1/client/endpoint/get_endpoint_id_config_parameters.go
diff --git a/api/v1/client/endpoint/get_endpoint_id_healthz_parameters.go b/api/v1/client/endpoint/get_endpoint_id_healthz_parameters.go
diff --git a/api/v1/client/endpoint/get_endpoint_id_labels_parameters.go b/api/v1/client/endpoint/get_endpoint_id_labels_parameters.go
diff --git a/api/v1/client/endpoint/get_endpoint_id_log_parameters.go b/api/v1/client/endpoint/get_endpoint_id_log_parameters.go
diff --git a/api/v1/client/endpoint/get_endpoint_id_parameters.go b/api/v1/client/endpoint/get_endpoint_id_parameters.go
diff --git a/api/v1/client/endpoint/patch_endpoint_id_config_parameters.go b/api/v1/client/endpoint/patch_endpoint_id_config_parameters.go
diff --git a/api/v1/client/endpoint/patch_endpoint_id_labels_parameters.go b/api/v1/client/endpoint/patch_endpoint_id_labels_parameters.go
diff --git a/api/v1/client/endpoint/patch_endpoint_id_parameters.go b/api/v1/client/endpoint/patch_endpoint_id_parameters.go
diff --git a/api/v1/client/endpoint/put_endpoint_id_parameters.go b/api/v1/client/endpoint/put_endpoint_id_parameters.go
diff --git a/api/v1/client/policy/get_fqdn_cache_id_parameters.go b/api/v1/client/policy/get_fqdn_cache_id_parameters.go
diff --git a/api/v1/models/endpoint_identifiers.go b/api/v1/models/endpoint_identifiers.go
diff --git a/api/v1/openapi.yaml b/api/v1/openapi.yaml
@@ -1094,7 +1094,8 @@ parameters:
         - cni-attachment-id: CNI attachment ID, e.g. cni-attachment-id:22222:eth0
         - container-id: Container runtime ID, e.g. container-id:22222 (deprecated, may not be unique)
         - container-name: Container name, e.g. container-name:foobar (deprecated, may not be unique)
-        - pod-name: pod name for this container if K8s is enabled, e.g. pod-name:default:foobar
+        - pod-name: pod name for this container if K8s is enabled, e.g. pod-name:default:foobar (deprecated, may not be unique)
+        - cep-name: cep name for this container if K8s is enabled, e.g. pod-name:default:foobar-net1
         - docker-endpoint: Docker libnetwork endpoint ID, e.g. docker-endpoint:4444
     in: path
     required: true
@@ -1882,13 +1883,13 @@ definitions:
         description: Docker network ID
         type: string
       pod-name:
-        description: K8s pod for this endpoint(Deprecated, use K8sPodName and K8sNamespace instead)
+        description: K8s pod for this endpoint (deprecated, may not be unique)
         type: string
       k8s-pod-name:
-        description: K8s pod name for this endpoint
+        description: K8s pod name for this endpoint (deprecated, may not be unique)
         type: string
       k8s-namespace:
-        description: K8s namespace for this endpoint
+        description: K8s namespace for this endpoint (deprecated, may not be unique)
         type: string
   Labels:
     description: Set of labels
-Original file line number
+Diff line change
@@ Expand Up / @@ -178,6 +178,7 @@ cardinality @@
     cass
     cassandra
     cassandraparser
+    cep
     certgen
     certmanager
     cgroup
@@ Expand Down @@