Use const references

asd281533890 · Dec 5, 2017 · 448ccc2 · 448ccc2
1 parent 0ddd078
commit 448ccc2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/atom/browser/api/atom_api_window.cc b/atom/browser/api/atom_api_window.cc
@@ -177,10 +177,10 @@ Window::~Window() {
 }
 
 std::vector<base::FilePath::StringType> g_preloads;
-void Window::AddGlobalPreload(const base::FilePath::StringType preloadPath) {
+void Window::AddGlobalPreload(const base::FilePath::StringType& preloadPath) {
   g_preloads.push_back(preloadPath);
 }
-void Window::RemoveGlobalPreload(const base::FilePath::StringType preloadPath) {
+void Window::RemoveGlobalPreload(const base::FilePath::StringType& preloadPath) {
   g_preloads.erase(
     std::remove(g_preloads.begin(), g_preloads.end(), preloadPath),
     g_preloads.end());

diff --git a/atom/browser/api/atom_api_window.h b/atom/browser/api/atom_api_window.h
@@ -54,8 +54,8 @@ class Window : public mate::TrackableObject<Window>,
 
   int32_t ID() const;
 
-  static void AddGlobalPreload(const base::FilePath::StringType preloadPath);
-  static void RemoveGlobalPreload(const base::FilePath::StringType preloadPath);
+  static void AddGlobalPreload(const base::FilePath::StringType& preloadPath);
+  static void RemoveGlobalPreload(const base::FilePath::StringType& preloadPath);
   static std::vector<base::FilePath::StringType> GetGlobalPreloads();
 
  protected: