revert passing booleans into FullNameInputRow

ashishsah1000 · Jan 5, 2022 · 7c99096 · 7c99096
1 parent 43209e4
commit 7c99096
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/components/FullNameInputRow.js b/src/components/FullNameInputRow.js
@@ -5,7 +5,6 @@ import _ from 'underscore';
 import styles from '../styles/styles';
 import withLocalize, {withLocalizePropTypes} from './withLocalize';
 import TextInput from './TextInput';
-import * as PersonalDetails from '../libs/actions/PersonalDetails';
 
 const propTypes = {
     ...withLocalizePropTypes,
@@ -19,14 +18,14 @@ const propTypes = {
     /** Used to prefill the firstName input, can also be used to make it a controlled input */
     firstName: PropTypes.string,
 
-    /** If first name input should show error */
-    hasFirstNameError: PropTypes.bool,
+    /** Error message to display below firstName input */
+    firstNameError: PropTypes.string,
 
     /** Used to prefill the lastName input, can also be used to make it a controlled input */
     lastName: PropTypes.string,
 
-    /** If last name input should show error */
-    hasLastNameError: PropTypes.bool,
+    /** Error message to display below lastName input */
+    lastNameError: PropTypes.string,
 
     /** Additional styles to add after local styles */
     style: PropTypes.oneOfType([
@@ -36,9 +35,9 @@ const propTypes = {
 };
 const defaultProps = {
     firstName: '',
-    hasFirstNameError: false,
+    firstNameError: '',
     lastName: '',
-    hasLastNameError: false,
+    lastNameError: '',
     style: {},
 };
 
@@ -50,7 +49,7 @@ const FullNameInputRow = (props) => {
                 <TextInput
                     label={props.translate('common.firstName')}
                     value={props.firstName}
-                    errorText={PersonalDetails.getMaxCharacterError(props.hasFirstNameError)}
+                    errorText={props.firstNameError}
                     onChangeText={props.onChangeFirstName}
                     placeholder={props.translate('profilePage.john')}
                 />
@@ -59,7 +58,7 @@ const FullNameInputRow = (props) => {
                 <TextInput
                     label={props.translate('common.lastName')}
                     value={props.lastName}
-                    errorText={PersonalDetails.getMaxCharacterError(props.hasLastNameError)}
+                    errorText={props.lastNameError}
                     onChangeText={props.onChangeLastName}
                     placeholder={props.translate('profilePage.doe')}
                 />

diff --git a/src/pages/RequestCallPage.js b/src/pages/RequestCallPage.js
@@ -25,6 +25,7 @@ import KeyboardAvoidingView from '../components/KeyboardAvoidingView';
 import RequestCallIcon from '../../assets/images/request-call.svg';
 import LoginUtil from '../libs/LoginUtil';
 import * as ValidationUtils from '../libs/ValidationUtils';
+import * as PersonalDetails from '../libs/actions/PersonalDetails';
 
 const propTypes = {
     ...withLocalizePropTypes,
@@ -222,9 +223,9 @@ class RequestCallPage extends Component {
                         </Text>
                         <FullNameInputRow
                             firstName={this.state.firstName}
-                            hasFirstNameError={this.state.firstNameError}
+                            hasFirstNameError={PersonalDetails.getMaxCharacterError(this.state.firstNameError)}
                             lastName={this.state.lastName}
-                            hasLastNameError={this.state.lastNameError}
+                            hasLastNameError={PersonalDetails.getMaxCharacterError(this.state.lastNameError)}
                             onChangeFirstName={firstName => this.setState({firstName})}
                             onChangeLastName={lastName => this.setState({lastName})}
                             style={[styles.mv4]}