perf(npm): reduce use of .keys() for has-key checks

js/private/js_helpers.bzl

@@ -232,7 +232,7 @@ def envs_for_log_level(log_level):
         A list of environment variables to set to turn on the js_binary runtime
         logs for the given log level. Typically, they are each set to "1".
     """
-    if log_level not in LOG_LEVELS.keys():
+    if LOG_LEVELS.get(log_level, 0) == 0:
         msg = "log_level must be one of {} but got {}".format(LOG_LEVELS.keys(), log_level)
         fail(msg)
     envs = []

npm/private/npm_translate_lock_generate.bzl

@@ -174,12 +174,12 @@ sh_binary(
                 dep_importer = paths.normalize("{}/{}".format(import_path, dep_version) if import_path else dep_version)
                 dep_path = helpers.link_package(root_package, import_path, dep_version)
                 dep_key = "{}+{}".format(dep_package, dep_path)
-                if dep_key in fp_links.keys():
+                if fp_links.get(dep_key, False):
                     fp_links[dep_key]["link_packages"][link_package] = True
                 else:
                     transitive_deps = {}
                     raw_deps = {}
-                    if dep_importer in importers.keys():
+                    if importers.get(dep_importer, False):
                         raw_deps = importers.get(dep_importer).get("deps")
                     for raw_package, raw_version in raw_deps.items():
                         package_store_name = utils.package_store_name(raw_package, raw_version)
@@ -457,7 +457,7 @@ def npm_link_all_packages(name = "node_modules", imported_links = []):
     ]
 
     for filename, contents in rctx.attr.additional_file_contents.items():
-        if not filename in rctx_files.keys():
+        if not rctx_files.get(filename, False):
             rctx_files[filename] = contents
         elif filename.endswith(".bzl"):
             # bzl files are special cased since all load statements must go at the top

npm/private/pnpm.bzl

@@ -535,7 +535,7 @@ def _parse_lockfile(parsed, err):
 
     if not types.is_dict(parsed):
         return {}, {}, {}, "lockfile should be a starlark dict"
-    if "lockfileVersion" not in parsed.keys():
+    if not parsed.get("lockfileVersion", False):
         return {}, {}, {}, "expected lockfileVersion key in lockfile"
 
     # Lockfile version may be a float such as 5.4 or a string such as '6.0'

npm/private/pnpm_extension.bzl

@@ -36,7 +36,7 @@ def resolve_pnpm_repositories(modules):
                 Only the root module may override the default name for the pnpm repository.
                 This prevents conflicting registrations in the global namespace of external repos.
                 """)
-            if attr.name not in registrations.keys():
+            if not registrations.get(attr.name, False):
                 registrations[attr.name] = []
 
             v = attr.pnpm_version

npm/private/utils.bzl

@@ -197,7 +197,7 @@ def _replace_npmrc_token_envvar(token, npmrc_path, environ):
         # ${NPM_TOKEN} -> NPM_TOKEN
         # $NPM_TOKEN -> NPM_TOKEN
         token = token.removeprefix("$").removeprefix("{").removesuffix("}")
-        if token in environ.keys() and environ[token]:
+        if environ.get(token, False):
             token = environ[token]
         else:
             # buildifier: disable=print