[red-knot] feat: implement all rich comparison operators #13635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algorithm for rich comparison still has some todo items
|
We may want to get this in place soon; let us know if you'd like to continue with it, or if it would be better for one of us to pick it up and get it ready to land! |
|
Hi, I've been a bit busy with work recently, I don't mind if someone picks the ticket! Do you want me to close the draft PR? |
|
No problem, thanks for replying! (And for all your contributions over the last few weeks.) No need to close this PR, it may be useful reference / starting point. But (until/unless we hear otherwise) we'll assume that you aren't working on it and it's safe for one of us to pick it up from here, without duplicating work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm for rich comparison still has some todo items
Summary
The algorithm to perform rich comparisons on instances is non trivial. #13571 introduced a placeholder for
__lt__.This PR addresses some of the
// TODOand contributes towards #13618.Test Plan
To be done, this is why the PR is still a draft