Upgrade salsa #13757
Upgrade salsa #13757
Conversation
| Type::StringLiteral(StringLiteralType::new(db, "True".into())) | ||
| Type::StringLiteral(StringLiteralType::new(db, Box::<str>::from("True"))) |
There was a problem hiding this comment.
I'm curious to know why this and other related changes are being made. I do prefer using ::from instead of .into because it makes the conversion visible without peeking through the definition to know the final type.
There was a problem hiding this comment.
salsa-rs/salsa#589 added a way to lookup interned types with borrowed values (rather than owned values). This made the new constructor generic. I think I'm going to wait for salsa-rs/salsa#594 because we can then change StringLiteralType::new to be called with "True" and avoid allocating if the value has already been interned.
|
Cargo.toml
Outdated
There was a problem hiding this comment.
nit: there's lots of whitespace changes here that made the diff a bit harder to review. Not asking you to revert them as it would just be a waste of your time, just a comment for future PRs
There was a problem hiding this comment.
Sorry for that. RustRover loves to auto format files :(
MichaReiser
force-pushed
the
micha/upgrade-salsa-15-10
branch
from
70bce88
to
a52e294
Compare
This pulls in a MIRI fix and salsa-rs/salsa#589 which allows us to look up interned structs by using a borrowed value (e.g.
StringLiteralTypecan be resolved using a&strwithout having to allocate aBox<str>first.