Remove unnecessary module declarations

ataulm · Oct 11, 2018 · 19335c1 · 19335c1
1 parent 04cd5dd
commit 19335c1
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 60 deletions.
diff --git a/app/src/main/java/io/plaidapp/dagger/HomeComponent.kt b/app/src/main/java/io/plaidapp/dagger/HomeComponent.kt
@@ -19,17 +19,15 @@ package io.plaidapp.dagger
 import android.content.Context
 import dagger.BindsInstance
 import dagger.Component
-import io.plaidapp.core.dagger.CoroutinesContextProviderModule
 import io.plaidapp.core.dagger.DataManagerModule
-import io.plaidapp.core.dagger.dribbble.DribbbleDataModule
-import io.plaidapp.core.dagger.dribbble.DribbbleRetrofitModule
 import io.plaidapp.core.dagger.FilterAdapterModule
 import io.plaidapp.core.dagger.OnDataLoadedModule
-import io.plaidapp.core.dagger.dribbble.DribbleSearchServiceProvider
-import io.plaidapp.core.dagger.ShotsRepositoryModule
 import io.plaidapp.ui.HomeActivity
 
-@Component(modules = [HomeModule::class, ShotsRepositoryModule::class])
+/**
+ * Dagger component for the [HomeActivity].
+ */
+@Component(modules = [HomeModule::class])
 interface HomeComponent {
 
     fun inject(activity: HomeActivity)
@@ -41,14 +39,9 @@ interface HomeComponent {
         @BindsInstance
         fun context(context: Context): Builder
 
-        fun coroutinesContextProviderModule(module: CoroutinesContextProviderModule): Builder
         fun dataLoadedModule(module: OnDataLoadedModule): Builder
         fun dataManagerModule(module: DataManagerModule): Builder
-        fun dribbbleDataModule(module: DribbbleDataModule): Builder
-        fun retrofitModule(module: DribbbleRetrofitModule): Builder
         fun homeModule(module: HomeModule): Builder
         fun filterAdapterModule(module: FilterAdapterModule): Builder
-        fun searchRemoteDataSourceModule(module: DribbleSearchServiceProvider): Builder
-        fun shotsRepositoryModule(module: ShotsRepositoryModule): Builder
     }
 }
diff --git a/app/src/main/java/io/plaidapp/dagger/HomeModule.kt b/app/src/main/java/io/plaidapp/dagger/HomeModule.kt
@@ -22,25 +22,12 @@ import com.bumptech.glide.util.ViewPreloadSizeProvider
 import dagger.Module
 import dagger.Provides
 import io.plaidapp.R
-import io.plaidapp.core.dagger.CoroutinesContextProviderModule
 import io.plaidapp.core.dagger.DataManagerModule
-import io.plaidapp.core.dagger.dribbble.DribbbleDataModule
-import io.plaidapp.core.dagger.FilterAdapterModule
 import io.plaidapp.core.dagger.OnDataLoadedModule
-import io.plaidapp.core.dagger.ShotsRepositoryModule
 import io.plaidapp.core.data.pocket.PocketUtils
 import io.plaidapp.core.dribbble.data.api.model.Shot
 
-@Module(
-    includes = [
-        CoroutinesContextProviderModule::class,
-        DataManagerModule::class,
-        DribbbleDataModule::class,
-        FilterAdapterModule::class,
-        ShotsRepositoryModule::class,
-        OnDataLoadedModule::class
-    ]
-)
+@Module(includes = [DataManagerModule::class, OnDataLoadedModule::class])
 class HomeModule(private val activity: Activity) {
 
     @Provides fun context(): Context = activity

diff --git a/app/src/main/java/io/plaidapp/dagger/Injector.kt b/app/src/main/java/io/plaidapp/dagger/Injector.kt
@@ -16,14 +16,9 @@
 
 package io.plaidapp.dagger
 
-import io.plaidapp.core.dagger.CoroutinesContextProviderModule
 import io.plaidapp.core.dagger.DataManagerModule
-import io.plaidapp.core.dagger.dribbble.DribbbleDataModule
-import io.plaidapp.core.dagger.dribbble.DribbbleRetrofitModule
 import io.plaidapp.core.dagger.FilterAdapterModule
 import io.plaidapp.core.dagger.OnDataLoadedModule
-import io.plaidapp.core.dagger.dribbble.DribbleSearchServiceProvider
-import io.plaidapp.core.dagger.ShotsRepositoryModule
 import io.plaidapp.core.data.BaseDataManager
 import io.plaidapp.core.data.PlaidItem
 import io.plaidapp.ui.HomeActivity
@@ -42,15 +37,10 @@ object Injector {
     ) {
         DaggerHomeComponent.builder()
             .context(activity)
-            .coroutinesContextProviderModule(CoroutinesContextProviderModule())
             .dataLoadedModule(OnDataLoadedModule(dataLoadedCallback))
             .dataManagerModule(DataManagerModule(activity))
-            .dribbbleDataModule(DribbbleDataModule())
             .homeModule(HomeModule(activity))
             .filterAdapterModule(FilterAdapterModule(activity))
-            .retrofitModule(DribbbleRetrofitModule())
-            .searchRemoteDataSourceModule(DribbleSearchServiceProvider())
-            .shotsRepositoryModule(ShotsRepositoryModule())
             .build()
             .inject(activity)
     }

diff --git a/core/src/main/java/io/plaidapp/core/dagger/DataManagerComponent.kt b/core/src/main/java/io/plaidapp/core/dagger/DataManagerComponent.kt
diff --git a/core/src/main/java/io/plaidapp/core/dagger/OnDataLoadedModule.kt b/core/src/main/java/io/plaidapp/core/dagger/OnDataLoadedModule.kt
@@ -21,6 +21,9 @@ import dagger.Provides
 import io.plaidapp.core.data.BaseDataManager
 import io.plaidapp.core.data.PlaidItem
 
+/**
+ * Module to provide [BaseDataManager.OnDataLoadedCallback].
+ */
 @Module class OnDataLoadedModule(private val callback: BaseDataManager.OnDataLoadedCallback<List<PlaidItem>>) {
 
     @Provides fun provideOnDataLoadedCallback() = callback

diff --git a/core/src/main/java/io/plaidapp/core/dagger/ShotsRepositoryModule.kt b/core/src/main/java/io/plaidapp/core/dagger/ShotsRepositoryModule.kt
@@ -18,7 +18,7 @@ package io.plaidapp.core.dagger
 
 import dagger.Module
 import dagger.Provides
-import io.plaidapp.core.dagger.dribbble.DribbleSearchServiceProvider
+import io.plaidapp.core.dagger.dribbble.DribbbleSearchServiceModule
 import io.plaidapp.core.data.CoroutinesContextProvider
 import io.plaidapp.core.dribbble.data.ShotsRepository
 import io.plaidapp.core.dribbble.data.search.SearchRemoteDataSource
@@ -28,7 +28,7 @@ import io.plaidapp.core.dribbble.data.search.SearchRemoteDataSource
  *
  * TODO: make this an app wide singleton.
  */
-@Module(includes = [CoroutinesContextProviderModule::class, DribbleSearchServiceProvider::class])
+@Module(includes = [CoroutinesContextProviderModule::class, DribbbleSearchServiceModule::class])
 class ShotsRepositoryModule {
 
     @Provides fun provideShotsRepository(

diff --git a/.../dribbble/DribbleSearchServiceProvider.kt → ...r/dribbble/DribbbleSearchServiceModule.kt b/.../dribbble/DribbleSearchServiceProvider.kt → ...r/dribbble/DribbbleSearchServiceModule.kt
@@ -21,8 +21,11 @@ import dagger.Provides
 import io.plaidapp.core.dribbble.data.search.DribbbleSearchService
 import io.plaidapp.core.dribbble.data.search.SearchRemoteDataSource
 
+/**
+ * Module to provide [DribbbleSearchService].
+ */
 @Module(includes = [DribbbleDataModule::class])
-class DribbleSearchServiceProvider {
+class DribbbleSearchServiceModule {
 
     @Provides fun provideDribbbleSearchService(dribbbleSearchService: DribbbleSearchService) =
         SearchRemoteDataSource.getInstance(dribbbleSearchService)