[AXON-41] Add error boundary to all pages except JIRA #59
Conversation
sdzh-atlassian
requested review from
bwieger-atlassian-com and
cabella-dot
as code owners
sdzh-atlassian
force-pushed
the
AXON-41-boundary-everywhere
branch
from
99ea619 to
6d24736
Compare
| SettingsPage = 'settings', | ||
| WelcomePage = 'welcome', | ||
|
|
||
| BitbucketIssuePage = 'bitbucketIssue', |
There was a problem hiding this comment.
Are we happy with the naming conventions here as we look at the next several years?
There was a problem hiding this comment.
The honest answer is that I'm not particularly happy with any of this, lol :D The idea was to somehow list the pages we have today, to somehow represent them in analytics. This isn't very future proof - for what it's worth, it's kind of already not very "present-proof", with how there are 2 start work pages xD
Super open to alternative suggestions here
There was a problem hiding this comment.
Here are some prior art on this:
https://posthog.com/docs/product-analytics/best-practices
In summary:
- use colon to separate main ideas
: - use underscore to separate words
_in a given idea - start with the high level and go to the low level
- version the appropriate idea (eg: v1, v2, v3 ...)
- do keep a consistent vocabulary (eg: always
...button:click, never...clicky_thing:tap)
Good Example:
start_work_page:start_work_button:click
start_work_page_v2:start_work_button:click
Don'ts:
- Don't use old vs new. What happens when you need the next news?
There was a problem hiding this comment.
Hmm, I'm happy with any naming convention here, so let's go with this :) Let's address it in a follow-up PR though if that's OK? Just to minimize the number of rebases :D
| @@ -138,6 +140,7 @@ export function usePipelineSummaryController(): [PipelineSummaryState, PipelineS | |||
| refresh: sendRefresh, | |||
| rerun: rerun, | |||
| fetchLogs: fetchLogs, | |||
| postMessage: postMessage, | |||
| }; | |||
| }, [sendRefresh, rerun, fetchLogs]); | |||
There was a problem hiding this comment.
See GitHub Action warning about React Hook
| @@ -8,6 +8,24 @@ export enum AnalyticsChannels { | |||
| AtlascodeUiErrors = 'atlascode.ui.errors', | |||
| } | |||
|
|
|||
| export enum AnalyticsView { | |||
| OnboardingPage = 'onboarding', | |||
There was a problem hiding this comment.
Example here:
onboarding_page:view
sdzh-atlassian
dismissed
bwieger-atlassian-com’s stale review
The base branch was changed.
sdzh-atlassian
force-pushed
the
AXON-41-boundary-everywhere
branch
from
6d24736 to
a289c70
Compare
|
Rebased onto main, merging |
What is this?
AtlascodeErrorBoundaryis now added to all pages of the newer architectureHow was this tested?