Do not trace when in debug

attaradev · Jul 22, 2021 · 4c76071 · 4c76071
1 parent 2b80149
commit 4c76071
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/android/app/src/main/java/com/expensify/chat/StartupTimer.java b/android/app/src/main/java/com/expensify/chat/StartupTimer.java
@@ -1,4 +1,6 @@
 package com.expensify.chat;
+import android.util.Log;
+
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContextBaseJavaModule;
 import com.facebook.react.bridge.ReactMethod;
@@ -27,7 +29,11 @@ public void stop() {
     }
 
     public static void start() {
-        trace = FirebasePerformance.getInstance().newTrace("js_loaded");
-        trace.start();
+        if (BuildConfig.DEBUG) {
+            Log.d("StartupTimer", "Metric tracing disabled in DEBUG");
+        } else {
+            trace = FirebasePerformance.getInstance().newTrace("js_loaded");
+            trace.start();
+        }
     }
 }
diff --git a/ios/ExpensifyCash/AppDelegate.m b/ios/ExpensifyCash/AppDelegate.m
@@ -74,6 +74,10 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
   center.delegate = self;
 
   [RNBootSplash initWithStoryboard:@"BootSplash" rootView:rootView]; // <- initialization using the storyboard file name
+
+  // Start the "js_load" custom performance tracing metric. This timer is stopped by a native
+  // module in the JS so we can measure total time starting in the native layer and ending in
+  // the JS layer.
   [RCTStartupTimer start];
   return YES;
 }

diff --git a/ios/ExpensifyCash/RCTStartupTimer.m b/ios/ExpensifyCash/RCTStartupTimer.m
@@ -12,12 +12,19 @@ @implementation RCTStartupTimer
 static FIRTrace *trace = nil;
 
 + (void)start {
+  #if DEBUG
+    // We don't want to record this on debug since it will skew the metrics we collect
+    NSLog(@"[StartupTimer] Metric tracing disabled in DEBUG");
+  #else
     trace = [FIRPerformance startTraceWithName:@"js_loaded"];
+  #endif
 }
 
 RCT_EXPORT_METHOD(stop)
 {
-  [trace stop];
+  if (trace) {
+    [trace stop];
+  }
 }
 
 // To export a module named StartupTimer